Incorrect segment id for direction calculations #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzychu124
added
BUG
kvakvs
approved these changes
Jun 23, 2022
kianzarrin
reviewed
Jun 23, 2022
| @@ -170,7 +170,7 @@ public class ExtSegmentEndManager | |||
|
|
|||
| public ArrowDirection GetDirection(ushort segmentId0, ushort segmentId1, ushort nodeId = 0) { | |||
| if (nodeId == 0) { | |||
| ref NetSegment netSegment = ref ((ushort)0).ToSegment(); | |||
| ref NetSegment netSegment = ref segmentId0.ToSegment(); | |||
There was a problem hiding this comment.
lol where did ((ushort)0) came from?!
There was a problem hiding this comment.
automated search and replace I suppose.
There was a problem hiding this comment.
I was the one who wrote the previous code.
kianzarrin
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the code since it does not make any sense when node id was not passed as argument - it suppose to calculate the id by taking shared node - ID 0 is always reserved and used as "Empty/Invalid".
That method is currently used in two places in both cases we pass node Id so this change doesn't really improve anything but will prevent bugs if someone try to use it without explicitly passing the node id.