Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading TM:PE data failed - notify the user #1617

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Loading TM:PE data failed - notify the user #1617

merged 4 commits into from
Jul 26, 2022

Conversation

krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Jul 21, 2022 •
edited

  • display warning message if loading TMPE data failed.
  • fixed possible NullReferenceException while trying to determine vehicle type and asset is broken

Closes #1412 , closes #1426

  • removed unused code in KeybindSettingsBase

Closes #1520

Build zip

@krzychu124 krzychu124 added BUG Defect detected UI User interface updates code cleanup Refactor code, remove old code, improve maintainability serialization load/store data in memory or on disk labels Jul 21, 2022
@krzychu124 krzychu124 added this to the 11.6.6.0 milestone Jul 21, 2022
@krzychu124 krzychu124 self-assigned this Jul 21, 2022
chameleon-tbn
chameleon-tbn approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@krzychu124 krzychu124 merged commit 76e228a into master Jul 26, 2022
@krzychu124 krzychu124 deleted the bugfix/forward-loading-fail-message branch July 26, 2022 18:38
@krzychu124 krzychu124 mentioned this pull request Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@chameleon-tbn chameleon-tbn chameleon-tbn approved these changes

@kianzarrin kianzarrin Awaiting requested review from kianzarrin

Assignees

@krzychu124 krzychu124

Labels
BUG Defect detected code cleanup Refactor code, remove old code, improve maintainability serialization load/store data in memory or on disk UI User interface updates
Projects
None yet
Milestone
11.6.6.0
3 participants
@krzychu124 @kvakvs @chameleon-tbn