Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop while traversing segments of node #1619

Merged
merged 4 commits into from
Jul 31, 2022
Merged

Infinite loop while traversing segments of node #1619

merged 4 commits into from
Jul 31, 2022

Conversation

krzychu124
Copy link
Member

  • limit number of iterations - node can be connected to 8 segments only
  • fixes possible infinite loop due to network configuration properties - parallel segments iteration e.g.: CSUR merge, diverge segments

Fixes #1612 , fixes #1439

Build ZIP

@krzychu124 krzychu124 added BUG Defect detected confirmed Represents confirmed issue or bug SPEED LIMITS Feature: Speed limits Overlays Overlays, data vis, etc. labels Jul 26, 2022
@krzychu124 krzychu124 added this to the 11.6.7.0 milestone Jul 26, 2022
@krzychu124 krzychu124 self-assigned this Jul 26, 2022
@krzychu124 krzychu124 modified the milestones: 11.6.7.0, 11.6.6.1 Jul 30, 2022
kianzarrin
kianzarrin approved these changes Jul 31, 2022
View reviewed changes
Copy link
Collaborator

@kianzarrin kianzarrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

counter is too generic variable name. I'd call it watchdog. Other than that looks good.

@krzychu124 krzychu124 merged commit 57ffce1 into master Jul 31, 2022
@krzychu124 krzychu124 deleted the bugfix/1612-infinite-loop-traversing-node-segments branch July 31, 2022 16:56
@krzychu124 krzychu124 mentioned this pull request Jul 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@kianzarrin kianzarrin kianzarrin approved these changes

@DaEgi01 DaEgi01 Awaiting requested review from DaEgi01

Assignees

@krzychu124 krzychu124

Labels
BUG Defect detected confirmed Represents confirmed issue or bug Overlays Overlays, data vis, etc. SPEED LIMITS Feature: Speed limits
Projects
None yet
Milestone
11.6.6.1
Development

Successfully merging this pull request may close these issues.

Crashing on CSUR elements "Speed limits stuck at intersections" - user report
3 participants
@krzychu124 @kvakvs @kianzarrin