Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMPE settings not applied immediately after loading the savegame #1625

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Aug 1, 2022

#1624

  • moved Harmony patches installation to earlier step of loading process to prevent network update desync and make it mod load order independent
  • the change does not break hot-reload - in both situations mod initialization process goes in the same order

Other

  • fixed NullReferenceException on exit to the Main menu or when user try to reload savegame

Build zip

@krzychu124 krzychu124 added BUG Defect detected confirmed Represents confirmed issue or bug STABLE TM:PE STABLE branch Harmony serialization load/store data in memory or on disk TEST TEST version of the mod / workshop page labels Aug 1, 2022
@krzychu124 krzychu124 added this to the 11.6.6.2 milestone Aug 1, 2022
@krzychu124 krzychu124 self-assigned this Aug 1, 2022
Copy link
Collaborator

@kianzarrin kianzarrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed on discord this is a quick fix. we need to see if we can apply all patches in preload.
also would be nice to avoid the need to update all lane arrows for dedicated turning lanes policy to save loading times.

don't forget to reopen #1624 after merge

Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work now flawless. at least i not able to reproduce my issue any more

@krzychu124 krzychu124 merged commit 19779d0 into master Aug 3, 2022
@krzychu124 krzychu124 deleted the bugfix/1624-network-not-reflecting-mod-settings branch August 3, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Defect detected confirmed Represents confirmed issue or bug Harmony serialization load/store data in memory or on disk STABLE TM:PE STABLE branch TEST TEST version of the mod / workshop page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants