#264: disable incompatible mod warning

[krzychu124]

Resolves #264 and resolves #284

Key features:

• checkbox in options menu to turn off checking for incompatible mods
• checkbox at the bottom of Incompatible mods detected dialog to turn off checking at next startup or mod enable (does the same as option above)
• value is persisted in TMPE_GlobalConfig.xml

Minor bug to solve before merging: [Fixed in latest commit]
- when incompatible mods detected, Autorun at startup checkbox state in the Incompatible mods detected dialog is not syncronized with corresponding value displayed in Mod options menu, but value change is properly saved to config.

TODO:

• run incompatible mod checker on demand e.g. from Mod options menu (visible only when entering from game main menu)
• implement Incompatible Detector Should Not Warn When Not Enabled #284 enhancement

[originalfoo]

Shall I add in the #284 filter to only check enabled mods?

[krzychu124]

Updated description 😉

[krzychu124]

It looks like it is working as intended 😃

[originalfoo]

The text of these options is too similar IMO:

What about:

o Scan for known incompatible mods on startup
    o Ignore disabled mods
o Notify me if a new mod conflict is detected at any time

What do you think?

[krzychu124]

Good point. I like it 😃

[originalfoo]

Or instead of:

o Notify me if a new mod conflict is detected at any time

Maybe:

o Notify me if there is an unexpected mod conflict

[originalfoo]

Maybe change to:

o Scan for known incompatible mods on startup

This way it uses same locale string as in mod options, and also more closely ties together the checkbox on the pop-up with the checkbox in mod options?

[originalfoo]

The options all seem to work as intended btw. Both on start up and also when enabling/disabling the mod.

[krzychu124]

I will make all changes tomorrow 😉

[originalfoo]

Missing update to https://github.com/krzychu124/Cities-Skylines-Traffic-Manager-President-Edition/blob/master/TLM/TLM/Resources/lang_template.txt which is used as basis of new localisations.

[krzychu124]

Good catch...
I think something is broken because I can't see that file in project files view 😕 Alphabetically sorted:

Anyway I'll update it 😃

[originalfoo]

Well, it shouldn't be included in the workshop package, which is why it's not in the solution.

I wonder if it's even needed, as we could just tell people to use the lang.txt as template instead?

I used the lang_template.txt in the localisation guide as that's what @VictorPhilipp had in the original wiki documentation for localisation. It's essentially a clone of lang.txt as far as I can tell.

[krzychu124]

I think that for translation better would be lang.txt because using just template you can't translate tutorial keys.

[Emphasia]

lang_zh.txt updated.

[originalfoo]

@krzychu124 I've updated the localisation page in wiki to state lang.txt should be used as template.

[originalfoo]

LGTM!

[originalfoo]

@FireController1847 Can you confirm the skipping disabled mods thing works as you expect?

[krzychu124]

I've updated translations from @Emphasia review and included those from PR in @VictorPhilipp repo as well

[originalfoo]

LGTM! Ok to merge?

[FireController1847]

Works as intended. Would be nice to ignore disabled by default but that's more of my personal preference haha. Skipping the 3-day wait time due to strong requests to merge approved by me!

[originalfoo]

I agree with @FireController1847 , having the 'ignore disabled' be active by default would be better.

Good catch @FireController1847 !

[krzychu124]

Changed 😉

[originalfoo]

LGTM!