Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lang_fr.txt #311

Merged
merged 2 commits into from
May 19, 2019
Merged

Update lang_fr.txt #311

merged 2 commits into from
May 19, 2019

Conversation

PierreTSE
Copy link
Contributor

  • Translate undone lines
  • Correct typos
  • Reword some translations to make all the file consistent

@PierreTSE
Update lang_fr.txt
381372d 
- Translate undone lines
- Correct typos
- Reword some translations to make all the file consistent
originalfoo
originalfoo requested changes May 11, 2019
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement, but I added comments to a few items for your consideration.

TLM/TLM/Resources/lang_fr.txt Show resolved Hide resolved
TLM/TLM/Resources/lang_fr.txt Show resolved Hide resolved
TLM/TLM/Resources/lang_fr.txt Show resolved Hide resolved
TLM/TLM/Resources/lang_fr.txt Show resolved Hide resolved
TLM/TLM/Resources/lang_fr.txt Outdated Show resolved Hide resolved
@originalfoo originalfoo added this to the 10.20 milestone May 12, 2019
@originalfoo originalfoo added Accessibility Color blindness, etc. Localisation Localised text and features Usability Make mod easier to use UI User interface updates and removed Accessibility Color blindness, etc. labels May 12, 2019
@originalfoo
Copy link
Member

@PierreTSE Will you be able to make the last couple of changes mentioned above? We'll be doing a release shortly for the Campus DLC update.

@PierreTSE
Update lang_fr.txt
fa55388 
Minor changes after reviewing.
@PierreTSE
Copy link
Contributor Author

This should be fine now !

originalfoo
originalfoo approved these changes May 19, 2019
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@originalfoo originalfoo merged commit b702fba into CitiesSkylinesMods:master May 19, 2019
originalfoo added a commit that referenced this pull request May 19, 2019
@originalfoo
Added French translation to release notes
5e0f038 
See PR #311
@originalfoo originalfoo mentioned this pull request May 19, 2019
Merged
originalfoo added a commit that referenced this pull request May 19, 2019
@originalfoo
Update CHANGELOG.md
8562c34 
Added note on French translation (#311)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@originalfoo originalfoo originalfoo approved these changes

Assignees
No one assigned
Labels
Localisation Localised text and features UI User interface updates Usability Make mod easier to use
Projects
None yet
Milestone
10.20
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PierreTSE @originalfoo