Differentiate Labs and Stable & Avoid Multiple Subscriptions

[krzychu124]

Added suffix LABS to differentiate labs and stable versions.

• when sources built using Release LABS configuration Version string is extended with LABS text e.g. TM:PE 10.21 LABS
• visible in Content Manager, Mod options tab and label of the mod main menu in-game (label is built from TM:PE + that Version string)

Fixes #326, Fixes #386

[originalfoo]

@krzychu124 Want me to add the changes suggested above to the PR?

[originalfoo]

Now that we have LABS token and thus a way to distinguish between two builds, I've also set it up to dynamically add the other version (LABS or STABLE, or both, depending on build) to incompatible mods checker. It still won't detect local builds but will at least drastically reduce number of end users having two versions of the mod installed and subsequent issues with road customisations not saving.

[originalfoo]

An object reference is required for the non-static field, method, or property 'TrafficManagerMod.Version'

Uhm, what did I do wrong?

Ah, it's actually in VersionLabel.cs:

namespace TrafficManager.UI.MainMenu {
	public class VersionLabel : UILabel {
		public override void Start() {
			size = new Vector2(MainMenuPanel.SIZE_PROFILES[0].MENU_WIDTH, MainMenuPanel.SIZE_PROFILES[0].TOP_BORDER); // TODO use current size profile
			text = "TM:PE " + TrafficManagerMod.Version; // <-- this line ########
			relativePosition = new Vector3(5f, 5f);
			textAlignment = UIHorizontalAlignment.Left;
		}
	}
}

[originalfoo]

Ok, that should fix the static error.

Here's summary of changes I made:

1. Split out the branch in to its own field (property? not sure about naming convention)
2. Updated the TM:PE toolbar caption so it includes -L, -D, or -S suffix denoting which build is active
3. Depending on build, add other TM:PE version(s) to the incompatible mod checker to help reduce number of users with multiple TM:PE versions installed. This still won't detect local builds, but it will reduce support workload of the "My road customisations aren't saving" variety.

@krzychu124 Can you check and see if it looks ok to you?

[originalfoo]

Ugh, just realised I did the incompatible mod checker bit wrong... Need to do some tweaks.

[originalfoo]

Ok, two more updates:

4. Fixed the blunder with incompatible mod checker
5. Changed title bar of incompatible mods dialog to include branch (otherwise it gets confusing af as you won't know which branch of TM:PE is throwing the warnings)

Tagging: #211, #306, #190, #149

[originalfoo]

Does help if I define workshop ids as ulong lol.

[originalfoo]

Ok, LGTM, but then it would... Needs additional reviewers.

[originalfoo]

Things to check in review:

• Content Manager > Mods shows branch (DEBUG, LABS, or STABLE) for your local build
• Mod options screen: mods list in sidebar shows branch for your local build
• TMPE toolbar in game shows abbreviated branch (might be too ugly, lmk what you think)
• Mod incompatibility checker detects duplicate subscriptions (it won't detect local build)
• Mod incompatibility dialog shows branch in title bar
• Mod incompatibility dialog shows branch on any duplicate subscriptions listed as conflicts

[originalfoo]

From #386:

• Rip out any remaining use of Linq, it doesn't work very well on OS X platform
• Add in some try .. catch wrappers to prevent exceptions reaching end users

[dymanoid]

• Rip out any remaining use of Linq, it doesn't work very well on OS X platform

AFAIK there are no issues with Linq in Mono, regardless of the target platform.

[originalfoo]

Tested everything I can think of and it seems to be working fine now.

Would appreciate another set of eyes to check over stuff before merging.

I've uploaded a fresh test version of the mod to workshop (published as RELEASE LABS) - it will check for both offline and other workshop versions: https://steamcommunity.com/sharedfiles/filedetails/?id=1781170897 and if you also do a local build set to DEBUG that will only check for the workshop versions.

[originalfoo]

Fixes #386

[FireController1847]

Other than these two I think it looks good

[krzychu124]

Tested, LGTM 👍