Keyboard Shortcuts for TM:PE

[kvakvs]

Note to reviewers

Please review with "Ignore whitespace" (⚙️ button above the diff view)

Changes

GUI settings page for keyboard shortcuts.
TMPE main window and 6 most used tools can be used with keyboard.
Settings are automatically saved by ColossalFramework.
Tooltips are shown on the menu buttons for the current keyboard shortcut.
FIXME: Tooltip on main crown button is not shown.
Stay in lane Shift+S shortcut does work

Checklist

• Secondary keyboard shortcut
• +click mouse combinations allowing to select only modifier keys Moved to Future stuff for keybinds tab #402
• Tooltips without a key should say nothing
• 👑 button tooltip is missing

[kvakvs]

Working to add another commit to this, which will also allow customizing Shift+S stay in lane key shortcut. At the time of writing, it works if it is not Shift+S for me, so something else is blocking it.

[krzychu124]

I think you forgot to add KeyMapping.cs to csproj because our CI is failing 😉

[FireController1847]

This is only my review for language files, aubergine needs to review the code.

[FireController1847]

Other than this one, it's pretty good. Don't forget to add translations for all the other languages.

[FireController1847]

Translations LGTM. Awaiting code review and it should be good to merge.

[kvakvs]

I need some help with Shift+S shortcut, it seemed to not work for me.
It works if I use something other than Shift+S though. Could it possibly be a SavedInputKey limitation?

[originalfoo]

I'm not sure how the game's own keymapping system works. Maybe it treats every shortcut as globally unique, rather than tool specific?

[kvakvs]

I believe it is SavedInputKey.IsPressed(Event.current) which is failing. So maybe something with Shift+letter, i've no idea need to investigate.

[krzychu124]

I will try to check what is going there when I'll be back home 😉

[krzychu124]

Ok, I think I found possible cause... https://github.com/krzychu124/Cities-Skylines-Traffic-Manager-President-Edition/blob/1f671ed2d0025b7f3a0be551d4e8c5d5c0dcf4bc/TLM/TLM/UI/SubTools/LaneConnectorTool.cs#L191
This Event.current is not the same even as that triggered in OnGui() method... Inside OnGui() Event has KeyCode.S but this Event.Current doesn't (it has character field set to 83'S', instead of KeyCode enum).

Main part of source code of public bool IsPressed(Event e)

// keyCode is our KeyCode to test against
// e.keyCode comes from Event
return keyCode != KeyCode.None && e.keyCode == keyCode && ... //and more checks there

Another issue, when I switched to Polish lang, tabs are wider and Keybinds tab is not accessible/not visible at all. (I will try to change translation of Maintenance tab in Polish)

Additionally sometimes some key combination Ctrl+Alt+C is locking in-game movement with WASD and mouse middle button - I can't rotate camera. Maybe not related with this PR

[kvakvs]

Fixed Shift+S shortcut now works, also done Delete/Bkspace in the same way, but did not add a new saved inputkey for it.

[originalfoo]

Just reviewing changed files and noticed the Russian translations were updated - was that you Kvakvs? (for changelog mention)

And German too?

[krzychu124]

Lang update, other features working great, no issues with modal.

[originalfoo]

One of the German locale strings is too long:

[originalfoo]

Overall looks really good! Lots of good code cleanup too :)

Spotted a couple of methods with Str() method name that isn't very descriptive. Some variance of using clause location (suggest outside namespace considering we only have one namespace per file).

Doing in-game testing now...

[originalfoo]

Keybind options tab UI feels very solid. Tried everything I can think of and so far not been able to break it. It feels nice and responsive too, and looks really great.

I noticed in code some stuff about row striping, but didn't see any on the UI? (not important, just mentioning it in case the rows were supposed to be striped)

[kvakvs]

@aubergine10

I noticed in code some stuff about row striping, but didn't see any on the UI? (not important, just mentioning it in case the rows were supposed to be striped)

The row striping code is still there. But in the old dialog the default background was grey-ish, and row striping code just cleared texture on some lines. In the new dialog i've no idea what the background sprite name is, so they are all black (i.e. not striped). Have to go into ModTool or UIHelper source and find the background sprite name which is used in other dialogs.

[originalfoo]

LGTM!

@kvakvs Think we can merge this now - but there's some inline tasks (eg. in OP) - do you want to carry those over to another issue (eg. #402 )?

[originalfoo]

Resolved merge conflict that was caused by #400

[kvakvs]

@aubergine10 You've already moved that +click task into #402 so that kind of removes it from here