Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it impossible to use TRACE option without DEBUG #455

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Make it impossible to use TRACE option without DEBUG #455

merged 1 commit into from
Jul 24, 2019

Conversation

kvakvs
Copy link
Collaborator

@kvakvs kvakvs commented Jul 24, 2019

Produces compile error if TRACE is defined but DEBUG is not defined
Fixes #454

originalfoo
originalfoo approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@originalfoo originalfoo added this to the 11.0 milestone Jul 24, 2019
@originalfoo originalfoo added code cleanup Refactor code, remove old code, improve maintainability technical Tasks that need to be performed in order to improve quality and maintainability labels Jul 24, 2019
krzychu124
krzychu124 approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kvakvs kvakvs merged commit deec16f into CitiesSkylinesMods:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@originalfoo originalfoo originalfoo approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

Assignees
No one assigned
Labels
code cleanup Refactor code, remove old code, improve maintainability technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

v11 - Trace in RELEASE build
3 participants
@kvakvs @originalfoo @krzychu124