Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TMPE.API Release LABS build config fix #456

Merged
merged 1 commit into from
Jul 24, 2019
Merged

TMPE.API Release LABS build config fix #456

merged 1 commit into from
Jul 24, 2019

Conversation

krzychu124
Copy link
Member

Fixed missing build configuration for TMPE.API project when Release LABS build configuration selected for solution.

@krzychu124 krzychu124 added technical Tasks that need to be performed in order to improve quality and maintainability 11 ALPHA TM:PE v11 alpha edition labels Jul 24, 2019
@krzychu124 krzychu124 self-assigned this Jul 24, 2019
kvakvs
kvakvs approved these changes Jul 24, 2019
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

originalfoo
originalfoo approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@originalfoo originalfoo added this to the 11.0 milestone Jul 24, 2019
@originalfoo
Copy link
Member

Out of interest, what issues would this cause to end-users?

@krzychu124
Copy link
Member Author

If you don't set build config for TMPE.API, you can't even build solution. I'm not sure which one you've selected while building alpha for workshop because there was no default configuration.

@krzychu124 krzychu124 merged commit c7d3558 into master Jul 24, 2019
@originalfoo originalfoo deleted the release-labs-fix branch September 4, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@originalfoo originalfoo originalfoo approved these changes

Assignees

@krzychu124 krzychu124

Labels
11 ALPHA TM:PE v11 alpha edition technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krzychu124 @originalfoo @kvakvs