Remove decorative and non-vehicle networks from speed limits manager. #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First commit ensures that non-vehicle networks (eg. decorative networks) and bicycle paths are skipped in the speed limit manager. Fixes #510 Second commit will add some logging either side of null netinfos to hopefully make source of them easier to track down (I suspect it's something to do with NExt2 or MOM). #Fixes #378
originalfoo
added
in-progress
Hopefully we can then track down their source.
originalfoo
added
under-review
|
Interesting note: This asset in workshop, which apparently works as a road, reports https://steamcommunity.com/sharedfiles/filedetails/?id=1398431305 |
originalfoo
changed the title
kvakvs
approved these changes
Aug 30, 2019
krzychu124
approved these changes
Aug 30, 2019
|
Actually, there's a few other reporting improvements to make here - brb |
|
Testing extended logging, found another road that doesn't specify vehicle types: https://steamcommunity.com/sharedfiles/filedetails/?id=1399095368 Same author. I'm in his discord server so I'll let him know direct. |
|
The check for |
Added a bunch of extra logging to the NetInfo scanner so we get more detail about any problems (will be useful to asset creators for example). One of the log messages (that checks for applicalbe `m_netAI`) was spammy so added a new debug switch `SpeedLimits` to toggle that on and off.
|
Added a bunch of extra logging to the NetInfo scanner so we get more detail about any problems (will be useful to asset creators for example). One of the log messages (that checks for applicalbe With new debug switch we could probably revisit the various Speed Limit classes at some later date to see if any other logging merits being toggled with that switch. Anyway, let me know what you think of the latest commit. |
|
Looks like document auto-format also un-indented |
|
|
kvakvs
reviewed
Aug 30, 2019
- Replaced a delegate with a lambda - Moved some stuff based on IDE suggestions - Completed a few obvious code comments Most of the remaining IDE warnings are about code comments, although there are a few things like "use private instead of internal" up near top of class.
|
Added notes for asset creators about requirements for ensuring their roads work with speed limits tool: |
Merged
Closed
This was referenced Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit ensures that non-vehicle networks (eg. decorative networks) and bicycle paths are skipped in the speed limit manager.
Fixes #510
Second commit adds some logging either side of null NetInfo warnings to hopefully make source of them easier to track down (I suspect it's something to do with NExt2 or MOM).
#Fixes #378