Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game language detection fix - modded language #534

Merged
merged 3 commits into from
Oct 20, 2019
Merged

Game language detection fix - modded language #534

merged 3 commits into from
Oct 20, 2019

Conversation

krzychu124
Copy link
Member

Fixes #533

  • fixed detection of game language when user is using 3rd party language mod

@krzychu124 krzychu124 added BUG Defect detected Localisation Localised text and features 11 ALPHA TM:PE v11 alpha edition labels Oct 19, 2019
@krzychu124 krzychu124 added this to the 11.0 milestone Oct 19, 2019
@krzychu124 krzychu124 self-assigned this Oct 19, 2019
@krzychu124 krzychu124 mentioned this pull request Oct 19, 2019
Closed
@originalfoo originalfoo added COMPATIBILITY Mod (in)compatibility / checker EXTERNAL Mod conflict or other external factor and removed BUG Defect detected labels Oct 19, 2019
originalfoo
originalfoo approved these changes Oct 20, 2019
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@krzychu124 krzychu124 merged commit 2d58a88 into master Oct 20, 2019
@krzychu124 krzychu124 deleted the 533-game-lang-3rd-party-lang-mod branch November 14, 2019 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@originalfoo originalfoo originalfoo approved these changes

Assignees

@krzychu124 krzychu124

Labels
11 ALPHA TM:PE v11 alpha edition COMPATIBILITY Mod (in)compatibility / checker EXTERNAL Mod conflict or other external factor Localisation Localised text and features
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

Cannot normally get using game language in 11.0 Third-party local translation.
2 participants
@krzychu124 @originalfoo