Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - manual traffic lights tool index out of range #545

Merged

Conversation

krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Nov 9, 2019

Fixed bug in ManualTrafficLights tool which prevented from correct rendering of traffic light buttons and threw an IndexOutOfRangeException.

Reported by user leonpeonleon on Discord

Side note: bug was there before Harmony merge...
It was hard to spot because of small difference in length of both arrays:

  • Nodes = 32,768
  • Segments = 36,864

…affic lights buttons rendering and threw indexOutOfRangeException
@krzychu124 krzychu124 added BUG Defect detected 11 ALPHA TM:PE v11 alpha edition TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc labels Nov 9, 2019
@krzychu124 krzychu124 added this to the 11.0 milestone Nov 9, 2019
@krzychu124 krzychu124 self-assigned this Nov 9, 2019
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@krzychu124 krzychu124 merged commit 4d86024 into master Nov 10, 2019
@originalfoo originalfoo deleted the bugfix/manual-traffic-lights-tool-index-out-of-range branch November 10, 2019 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 ALPHA TM:PE v11 alpha edition BUG Defect detected TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants