IterateNodeSegments sometimes does not work. Fixes #549 #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvakvs
reviewed
Nov 12, 2019
krzychu124
approved these changes
Nov 12, 2019
There was a problem hiding this comment.
Looks good to me.
When new node is created, (internally)game is attaching each new segment to first empty m_segmentX field it finds (with 0 value) where X is number 0-7
BTW, you can modify description to ' Fixes #549 ' to make Github automatically close issue when pull request will be merged 😉
kianzarrin
changed the title
krzychu124
added
BUG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #549 . See the issue for full dets.
I tested this and it works. Here is how I tested it:
This bug was breaking my roundabout detection. With this patch my roundabout detection works again.