default Timed traffic light #554

kianzarrin · 2019-11-17T22:56:03Z

Fixes #540
Fixes #5
Updates #324

added Mass edit modifier key (ctrl) for creating a default timed traffic light.
Updated tutorial message on https://crowdin.com/translate/tmpe/42/en-en#8862
Added tooltip keybind in the code but I don't know how to add a new key on crowdin.

I created this city to test my timed traffic light in all cases (that I could think of).

per lane type traffic light, separate lanes multi segment intersection, different road directions oneway roads introduce a problem: two sides are green rather than one/

Todo:Optimization and translations.

kvakvs

The keys to translation strings are too long, too detailed and contain extra spaces and typos.
Make the string keys shorter and move the text into Crowdin English and English UK variants.

TLM/TLM/UI/MainMenu/TimedTrafficLightsButton.cs

TLM/TLM/UI/SubTools/TimedTrafficLightsTool.cs

TLM/TLM/Util/AutoTimedTrafficLights.cs

kvakvs · 2019-11-19T11:51:49Z

Does the code verify that when a Timed TL is created, the directions are actually possible? By checking the lane connectors, lane arrows?

kianzarrin · 2019-11-22T02:54:30Z

@kvakvs

Does the code verify that when a Timed TL is created, the directions are actually possible? By checking the lane connectors, lane arrows?

I call the LaneArrowManger.SeparateLanes() to setup turning lanes. This function does nothing on the segments that have the lane connector.

If you try it, you will see that it works just fine. I did actually thought this through. If one puts a green light toward a direction that cannot be used:
A) The user will not see it because the already existing GUI render overlay code hides such directions.
B) It causes no functional issues. All the happens is that cars will not go toward that direction.

Note that at each step I give a green light to one of the connected road segments to go to all directions. So no change of logic is needed if lane connector is used.

put better tooltip keys.

kvakvs · 2019-11-23T12:04:51Z

Updated strings from Crowdin.
Tooltip.Keybinds: Auto TL not found. I have no idea how this works.

…s-Traffic-Manager-President-Edition into Timed_Traffic_Light

kianzarrin · 2019-11-26T03:52:09Z

I added wiki documentation here:
#540 (comment)

kvakvs · 2019-11-26T10:32:05Z

Been slightly confused. Is 554 (this) and 540 are the same problem but one is the issue and another is the pull request? Please add "Fixes #540" in the description, so when this is merged, the other one will be closed too.

kvakvs · 2019-11-26T10:34:28Z

Was wondering about a way to make this algorithm testable
(i.e. separate it from the game engine) and then create a simple unit test?
And then you can call the same auto TL engine from the test. Maybe read some text inputs with junction configurations and then check that output TL parameters are what we expect.

kianzarrin · 2019-11-26T19:28:12Z

@kvakvs

Was wondering about a way to make this algorithm testable

do you mean as part of this PR or another one?

kianzarrin · 2019-11-26T22:20:14Z

Been slightly confused. Is 554 (this) and 540 are the same problem but one is the issue and another is the pull request? Please add "Fixes #540" in the description, so when this is merged, the other one will be closed too.

This is just the first phase. There are more features discussed for example in #540 (comment)

Edit by aubergine: Fixed link

Do you think we should continue working on those in the same issue (#540) or should I create a new issue?

EDIT: tagging @aubergine10 @kvakvs

kianzarrin · 2019-11-26T22:21:44Z

I added in the translations. Is the code ready for approval? 😃

kvakvs · 2019-11-26T22:24:40Z

As you're steaming with new other ideas, i'm afraid once this is merged you won't have time to rework it and make it testable. Might as well consider that possibility now. If too complex i can let it slip for now, you might still want to do it later.

The idea is that you make algorithm not call any game or TMPE code, take some data structures as inputs, and output some data structures which will then be applied by the TMPE code to the game. This will allow us simulate those inputs during the test and check the outputs as they are simple numbers and structures now instead of game data. For this to work you need to know beforehand which parts of the map the algorithm will read and pre-load them into some simple arrays or lists or dicts, but don't store entire nodes and segments, only store stuff that's relevant to your algorithm.

krzychu124

I have no idea how you created those translation files without building TM:PE Crowdin project, but they are wrong 😄 All translation file are generated, we don't touch those files manually. I will push new translation to your branch 😉

krzychu124 · 2019-11-27T21:50:22Z

To resolve conflicts pull master branch and choose all translation files to overwrite yours.

kianzarrin · 2019-11-27T22:37:04Z

OK i resolved the merge conflicts as you said.

originalfoo · 2019-11-28T01:52:53Z

I'll do some testing on this tomorrow.

Note to self: Also, I need to create wiki page with docs

originalfoo · 2019-12-01T08:54:26Z

❌ I'm not seeing the Ctrl+Click mentioned in the tooltip:

✔️ It is, however, mentioned in the adviser text.

❌ Upon ctrl+clicking an existing junction (that had traffic light and also junction restrictions), I got this error:

Will try and gather more infos on the error (can't see anything of use in the logs yet).

originalfoo · 2019-12-01T08:56:34Z

For ref, here is the junction I was trying to customise:

originalfoo · 2019-12-01T09:07:32Z

Tested on several more junctions:

⚠️ ~~Any junction with 1-way roads throws up the empty info box~~
✔️ Works fine on junctions that have only 2-way roads

Also, it doesn't seem to factor in lane connectors (maybe those could be covered by later PR?)

originalfoo · 2019-12-01T09:15:41Z

Following image shows where it works and where it doesn't:

For road on left, it doesn't matter which direction the one-way road goes in, the auto-lights can still be applied.

So maybe it's when there's adjacent 1-way roads (like on Right) that the problem occurs?

kianzarrin · 2019-12-03T00:42:12Z

@aubergine10 Also, it doesn't seem to factor in lane connectors (maybe those could be covered by later PR?)

Yes it does. Just like lane separation quick-edit feature it ignores noes/segments with lane connections (still puts the Timed traffic light but does not separate turning lanes). Maybe it can be more clever see #575 . But not in this PR.

kianzarrin · 2019-12-03T00:53:42Z

@aubergine10 I'm not seeing the Ctrl+Click mentioned in the tooltip:

The English translation for for keybind was empty

"Tooltip.Keybinds:Auto TL","","","","","","","","","","Ctrl+Klik: Szybka instalacja","","","","","","","Автоматичне створення світлофора з таймером"	C:\Users\dell\source\repos\Cities-Skylines-Traffic-Manager-President-Edition\TLM\TLM\Resources\Translations\Menu.csv	21	1

Its was also empty in crowdin. I just added it: https://crowdin.com/translate/tmpe/24/en-en#8945

@aubergine10 @kvakvs @krzychu124 I do not know how to download translations the right way. Can anyone please help me?

kianzarrin · 2019-12-03T01:08:53Z

@aubergine10 ❌ Upon ctrl+clicking an existing junction (that had traffic light and also junction restrictions), I got this error:

Again a matter of translation key being empty. TTL quick-setup is not supported here. There has to be at least 3 exits from the junction. In here just add a simple traffic light. I don't see the need for timed traffic light. If you do then comment on #575

I will add all the missing English translations to crowdin. then I will wait for help from someone to import them.

kianzarrin · 2019-12-03T01:42:40Z

@aubergine10 I do not support level crossing. I just added code to show error message regarding this unsupported scenario. see #575

originalfoo · 2019-12-03T08:36:54Z

I do not know how to download translations the right way. Can anyone please help me?

You can download the .csv files and drop them in to the translations folder, then submit that to the PR - that's fine. Just be sure to leave a note in OP of PR listing which languages were changed and who changed them (so we can give credit in the change notes).

However:

All editing of the translations must occur via web interface of the Crowdin site; it is our single source of truth for current keys and translations
Adding new keys or languages to Crowdin needs to be done by an admin (myself, kvakvs, krzychu)

Note: I'm currently having some login issues with Crowdin (their support is investigating) so can't currently add languages or keys or approve translations.

kianzarrin · 2019-12-03T10:47:38Z

@aubergine10 You can download the .csv files and drop them in to the translations folder, then submit that to the PR - that's fine. Just be sure to leave a note in OP of PR listing which languages were changed and who changed them (so we can give credit in the change notes).

This is exactly what I did: #554 (comment) (If I understood correctly)

but then @krzychu124 told me: #554 (review)

they are wrong 😄 All translation file are generated

So @aubergine10 @kvakvs: can you please tell me what did I do wrong last time so that I can fix it this time?

PS: Also later on somehow the English translation strings in crowdin got wiped out leading to the empty error messages you saw! One of life's mysteries!

kianzarrin · 2019-12-04T02:54:56Z

OMG I totally forgot about left hand traffic! I will fix it soon.

kianzarrin · 2019-12-04T03:02:06Z

Fixed it.

kianzarrin · 2019-12-15T08:49:40Z

@aubergine10 @krzychu124 @kvakvs The translations are in. This should be ready to merge

originalfoo

From end-user perspective this LGTM 👍

kianzarrin added 6 commits November 10, 2019 05:18

basic auto timed traffic lights

342dd31

added Traffic lights with the following untested features:

330287c

per lane type traffic light, separate lanes multi segment intersection, different road directions oneway roads introduce a problem: two sides are green rather than one/

Completed Timed traffic lights with all the edge cases.

3befa27

Todo:Optimization and translations.

merged with master

b958903

Polished and documented the code

3bd5230

deleted uncessary file that I accidentially added

0aed330

originalfoo assigned kianzarrin Nov 18, 2019

originalfoo added enhancement Improve existing feature TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc labels Nov 18, 2019

originalfoo added this to the 11.0 milestone Nov 18, 2019

Added keybind tooltip

39a3af7

kvakvs requested changes Nov 19, 2019

View reviewed changes

removed commented out debug code.

44fc16f

put better tooltip keys.

kianzarrin requested a review from kvakvs November 22, 2019 03:56

originalfoo self-requested a review November 22, 2019 05:49

auto start TL

ad8d267

Merge branch 'master' of https://github.com/krzychu124/Cities-Skyline…

7ebf411

…s-Traffic-Manager-President-Edition into Timed_Traffic_Light

added translations.

0429efe

krzychu124 self-requested a review November 26, 2019 22:37

krzychu124 requested changes Nov 26, 2019

View reviewed changes

kianzarrin added 2 commits November 28, 2019 00:25

Merge branch 'master' into Timed_Traffic_Light

406b10c

resolved conflict my choosing all translation files from master

fa9d1d5

kianzarrin requested a review from krzychu124 November 27, 2019 22:36

kianzarrin mentioned this pull request Nov 28, 2019

more templates for timed traffic lights #575

Open

added error message for train tracks not supported.

6938092

kianzarrin added 2 commits December 4, 2019 03:49

added LHT logic

a0c8ba0

Merge remote-tracking branch 'initial/master' into Timed_Traffic_Light

0b0f79d

LHT logic

f16835f

kianzarrin added 2 commits December 15, 2019 09:13

Merge remote-tracking branch 'initial/master' into Timed_Traffic_Light

18563f5

Merge branch 'master' into Timed_Traffic_Light

3fe8ed5

originalfoo approved these changes Dec 15, 2019

View reviewed changes

kvakvs approved these changes Dec 23, 2019

View reviewed changes

krzychu124 approved these changes Dec 23, 2019

View reviewed changes

krzychu124 merged commit 30a7ce7 into CitiesSkylinesMods:master Dec 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

default Timed traffic light #554

default Timed traffic light #554

kianzarrin commented Nov 17, 2019 •

edited by originalfoo

kvakvs left a comment

kvakvs commented Nov 19, 2019

kianzarrin commented Nov 22, 2019

kvakvs commented Nov 23, 2019 •

edited

kianzarrin commented Nov 26, 2019

kvakvs commented Nov 26, 2019

kvakvs commented Nov 26, 2019

kianzarrin commented Nov 26, 2019

kianzarrin commented Nov 26, 2019 •

edited

kianzarrin commented Nov 26, 2019

kvakvs commented Nov 26, 2019 •

edited

krzychu124 left a comment •

edited

krzychu124 commented Nov 27, 2019

kianzarrin commented Nov 27, 2019

originalfoo commented Nov 28, 2019

originalfoo commented Dec 1, 2019

originalfoo commented Dec 1, 2019

originalfoo commented Dec 1, 2019 •

edited

originalfoo commented Dec 1, 2019 •

edited

kianzarrin commented Dec 3, 2019

kianzarrin commented Dec 3, 2019

kianzarrin commented Dec 3, 2019

kianzarrin commented Dec 3, 2019

originalfoo commented Dec 3, 2019

kianzarrin commented Dec 3, 2019 •

edited

kianzarrin commented Dec 4, 2019

kianzarrin commented Dec 4, 2019

kianzarrin commented Dec 15, 2019

originalfoo left a comment

default Timed traffic light #554

default Timed traffic light #554

Conversation

kianzarrin commented Nov 17, 2019 • edited by originalfoo

kvakvs left a comment

Choose a reason for hiding this comment

kvakvs commented Nov 19, 2019

kianzarrin commented Nov 22, 2019

kvakvs commented Nov 23, 2019 • edited

kianzarrin commented Nov 26, 2019

kvakvs commented Nov 26, 2019

kvakvs commented Nov 26, 2019

kianzarrin commented Nov 26, 2019

kianzarrin commented Nov 26, 2019 • edited

kianzarrin commented Nov 26, 2019

kvakvs commented Nov 26, 2019 • edited

krzychu124 left a comment • edited

Choose a reason for hiding this comment

krzychu124 commented Nov 27, 2019

kianzarrin commented Nov 27, 2019

originalfoo commented Nov 28, 2019

originalfoo commented Dec 1, 2019

originalfoo commented Dec 1, 2019

originalfoo commented Dec 1, 2019 • edited

originalfoo commented Dec 1, 2019 • edited

kianzarrin commented Dec 3, 2019

kianzarrin commented Dec 3, 2019

kianzarrin commented Dec 3, 2019

kianzarrin commented Dec 3, 2019

originalfoo commented Dec 3, 2019

kianzarrin commented Dec 3, 2019 • edited

kianzarrin commented Dec 4, 2019

kianzarrin commented Dec 4, 2019

kianzarrin commented Dec 15, 2019

originalfoo left a comment

Choose a reason for hiding this comment

kianzarrin commented Nov 17, 2019 •

edited by originalfoo

kvakvs commented Nov 23, 2019 •

edited

kianzarrin commented Nov 26, 2019 •

edited

kvakvs commented Nov 26, 2019 •

edited

krzychu124 left a comment •

edited

originalfoo commented Dec 1, 2019 •

edited

originalfoo commented Dec 1, 2019 •

edited

kianzarrin commented Dec 3, 2019 •

edited