Disambiguate LeftHandDrive to TrafficDrivesOnLeft

[originalfoo]

Fixes #577 - h/t @kianzarrin for reporting the issue

The term "LHD" (Left Hand Drive_r_) actually relates to traffic driving on the right (RHT, or Right Hand Traffic). However, TM:PE was regularly using the term to refer to the situation where traffic drives on the left (which is actually RHD / LHT).

To avoid ongoing mass confusion, this PR obsoletes Services.SimulationService.LeftHandDrive and adds a new disambiguous Services.SimulationService.TrafficDrivesOnLeft.

Uses of the obsolete property have been updated to use the new property. Also any instances of that code creating variables called lhd (ie. traffic drives on right) have been updated to lht (left hand traffic, which would be right hand driver).

Features affected include:

• Junction restrictions (particularly "Turn on Red")
• Lane arrows
• Lane connectors
• Priority signs
• Timed Traffic Lights
• Also, RoutingManager was updated, so anything that affects.

Everything should just work, as all that's changed is the property name, not it's value.

Side note: As far as I can tell, all uses of the now-obsolete LeftHandDrive property are updated to use TrafficDrivesOnLeft - should the obsolete property be removed?

[kvakvs]

Good stuff

[krzychu124]

I will check the code later but vanilla uses that term too. There is LeftHandDrive Vehicle.Flags and LeftHandDrive method in VehicleAI and SnowTruckAI so confusion is inevitable :)

[originalfoo]

I will check the code later but vanilla uses that term too. There is LeftHandDrive Vehicle.Flags and LeftHandDrive method in VehicleAI and SnowTruckAI so confusion is inevitable :)

Yes, vanilla is also incorrect in the terminology it uses = mass confusion.

Also, in some cases it will be valid to know which side driver is on - possibly for things like busses, trams, etc? In other words, which side do passengers transfer to the vehicle?

At some point it would be nice to try and wrap the vanilla wrongness in something less confusing but I'm lacking in C# knowledge as to how to fix that.

[krzychu124]

Looks good

[originalfoo]

I've created #581 to track future work to disambiguate the vanilla usage of LeftHandDrive.