boost lane marker hovering

[kianzarrin]

fixes #625
added DetermineHoveredLane() to DetermineHoveredElements(). Then I use this to find the correct lane marker.

declared HoveredLaneID in TrafficMangerTool and SubTool.

Additionally I took the opportunity and removed setters from SubTool.HoveredNodeID and SubTool.HoveredSegmentID. Such setters are unused, unnecessary and using them can cause bugs.

[kvakvs]

Nice

[krzychu124]

It doesn't fix anything regards raycasting, it makes marker selection weird in some cases, not to mention it makes detection a bit slower (~40-50%)

• before:
  Benchmark#MaybeCreateBenchmark#DetermineHoveredElements: avg. 0.06269605ms
• after:
  Benchmark#MaybeCreateBenchmark#DetermineHoveredElements: avg. 0.09171094ms
Benchmark#MaybeCreateBenchmark#DetermineHoveredElements: avg. 0.1039268ms

[kianzarrin]

@krzychu124

It doesn't fix anything regards raycasting.

There was a rendering issue and there was a raycasting issue. I changed the raycasting to use all the lane area rather than only marker. I have a feeling that when you say fix raycasting you mean something else.

not to mention it makes detection a bit slower (~40-50%)

Yeah I was worried about the performance. other pull requests I created reduce performance even more. There are ways to increase performance but should I? I mean 0.1ms is not much is it? If it is then we should create an issue and I can work on some ideas I have.

[kianzarrin]

This is really bad with bridges. I need to fix this.

[kvakvs]

Lane marker raycast should not target the ground level but the road plane, at the height where the marker is located. Then it will always look correct, at any height on or under any bridge. If that is done, then also render depth can be reduced to only cover range from slightly under the road level to slightly above the tallest car or train-car level.

[kianzarrin]

@kvakvs

Lane marker raycast should not target the ground level but the road plane,
My biggest problem with lane markers is when a truck is over it. targeting road plane does not help with that.
I am using mouse pos instead of hit pos which is wrong. I will fix that right now.

[kianzarrin]

@krzychu124

it makes marker selection weird in some cases

what is the expected behavior?

• in Lane connector: Hovering over lane points is difficult when cars and roads are passing over. #543 (comment) we agreed that I need to make the whole lane hoverable
• should I highlight the lane or only the lane marker? ( i prefer lane marker because I don't want it to look like xmass)
• what should be the behavior when the mouse pointer is on the node, should I highlight closest marker or should I hover nothing? (I prefer highlight closest lane marker)

[kianzarrin]

This still doesn't work when there is a bridge passing over selected markers.

[originalfoo]

testing...

[originalfoo]

Overall I like where this is heading; when it works, it works really well - much easier to pick and place the connector lines.

However, there are still some issues. You're probably aware of these, but I'll go through each one I found just in case...

Roads under bridges are cumbersome to work with

• Difficult to select node
• Difficult to select lane markers

Tunnels are also cumbersome to work with

• Difficult to select lane markers
• Underground view (PgDn while tool active) doesn't improve usability

Road bridges can be cubersome to work with

• Difficult to select lane markers on the bridge

Rail bridges are more cumbersome to work with

• The connector line does not appear

Nodeless junctions make some markers inaccessible

• A nodeless junction can result in lane markers appearing on top of each other
• Only the topmost marker can be selected
• Example below is from Railway collection; most of its networks have nodeless variants
• Any network that offers nodeless junctions (eg. some CSUE roads)
• I think in recent CSUR Toolbox mod they found a workaround (see "Bug Fixes" section in description of that mod)

Things I didn't test:

• Monorails
• Tram roads (in particular the LRT networks - especially sinking one - by clus will need testing)
• Metro
• The CSUE, CSUR, etc roads by AmamIya

[kianzarrin]

@aubergine10 OH no! why did you tested something I already had said it won't work? I was waiting for you guys to tell me if I should close down this review:

I am doing it now!

[originalfoo]

I liked the premise of the idea; in the places where it worked, it worked really well and made it easier to interact with the lane markers; sadly it just made other places much more difficult.