-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete junction restrictions #639
delete junction restrictions #639
Conversation
added check for isconfigurable. added check to silently return when flag is not changed. provided more documentation for the whole interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good and makes sense.
Can't seem to get this to work. I disabled some crosswalks on a junction: Then, with node still selected tried pressing Exit tool and then go back in to junction restrictions again for that node, settings still there: Tried pressing Also, didn't see any shortcuts mentioned on Keybinds settings in mod options: Nothing on the button tooltip either: Note: I renamed mod version to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above. The feature doesn't seem to be working.
sorry it was working with hovered segment. I fixed it. now it works with selected node. |
This is working great now, just one remaining issue: The |
@aubergine10
|
@aubergine10 I don't know why backspace does not work and delete does. it probably is a bug in Key bind settings.
I changed the tutorial message to include only delete key as the hotkey. Is that OK? |
I think we still need backspace support... @kvakvs Any idea why it's not working? |
@aubergine10 Of Course but does it have to block this pull request . Can't we do this as part of #568. if you really want backspace right NOW I can hack it through by checking for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Support for Backspace
moved to #568.
For 11.2 release it would be nice to get Delete
& Backspace
working across all applicable tools.
Fixes #623
I provided Interface for resting junction values. to do so provide
ternarybool.undefined
to aset<traffic rule>()
functionprovided documentation explaining what I explained in description of #623.
User Interface: choose Junction restriction tool -> select a junction -> press delete
or backspaceadded KeyDown
and KeyUpmethods to keybind settings mimickingInput.KeyDown()
andInput.KeyUp()
modified the crowding key : https://crowdin.com/translate/tmpe/42/en-en#8844 to explain the addition of hotkey. can someone approve and merge it please?