Centralise mod version #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shared assembly info file.
|
Looks good! Always wanted something like this; just as you'd spent ages trying to find way to get steam apps path, I'd spent ages trying to work out how to centralise the version info. Great to finally see this be a reality! Currently testing some other stuff but hope to get round to testing this in a few hours. |
originalfoo
approved these changes
Feb 9, 2020
originalfoo
added
code cleanup
kvakvs
approved these changes
Feb 10, 2020
krzychu124
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #678
Added SharedAssemblyInfo.cs to the solution. this file is added as "LINKED FILE" to every TMPE project:
including these projects: TLM TMPE.*
excluding these projects: CSUtil.Commons CSUtil.CameraInfo OptionsFramework
changed the
constversion string to a property whose value is same as the Version inSharedAssemblyInfo.csaccording to https://docs.microsoft.com/en-us/dotnet/api/system.reflection.assembly.getexecutingassembly?view=netframework-4.8Now there is only one place to change assembly version:
SharedAssemblyInfo.csAlso updated the copy rights also inside
SharedAssemblyInfo.csEDIT: I decided to do this because of #649 (comment)
EDIT:
you might notice some changes to TMPE.sln these changes are harmless and is mostly re-shufling lines. This is because when I added
SharedAssemblyInfo.csto solution VS decided to do some tidying up as well!VS does not let me revert TMPE.sln I tried to do it with a external editor but then I started to get errors. I'd say let TMPE.sln to be as it is.