Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mod options scrollbar position fix #722

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Mod options scrollbar position fix #722

merged 2 commits into from
Feb 21, 2020

Conversation

krzychu124
Copy link
Member

Fixes weird positioning of scrollbar.

Before:

After:

@krzychu124 krzychu124 added enhancement Improve existing feature UI User interface updates labels Feb 21, 2020
@krzychu124 krzychu124 added this to the 11.1.1 milestone Feb 21, 2020
@krzychu124 krzychu124 requested a review from a team February 21, 2020 00:06
@krzychu124 krzychu124 self-assigned this Feb 21, 2020
kvakvs
kvakvs reviewed Feb 21, 2020
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some magical numbers everywhere. Can't that be based on something reliable? Like row height, panel height, or something?

@krzychu124
Copy link
Member Author

Don't you know that I love magic numbers? 😄

Good point, I will try to make it better, maybe I'll make a little refactor there :)

originalfoo
originalfoo approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@krzychu124 krzychu124 merged commit 26f416f into master Feb 21, 2020
@krzychu124 krzychu124 deleted the fix-ui-scroll-position branch February 21, 2020 22:32
@originalfoo originalfoo added the Settings Road config, mod options, config xml label Feb 21, 2020
@originalfoo originalfoo mentioned this pull request Feb 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@originalfoo originalfoo originalfoo approved these changes

Assignees

@krzychu124 krzychu124

Labels
enhancement Improve existing feature Settings Road config, mod options, config xml UI User interface updates
Projects
None yet
Milestone
11.1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krzychu124 @kvakvs @originalfoo