Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hot reload mini-boost #725

Merged
merged 5 commits into from
Feb 22, 2020
Merged

hot reload mini-boost #725

merged 5 commits into from
Feb 22, 2020

Conversation

kianzarrin
Copy link
Collaborator

@kianzarrin kianzarrin commented Feb 22, 2020 •
edited

boosts #718
prevent double hot reload. Hot reload time is 12 sec.
prevent disabling tool after hot reload.
prevent unintentional disabling of other tools.

Test:

  • hot reload will reload TMPE only once (i checked log)
  • new TMPE menu does not get disabled 10 sec after hot reload.
  • EDIT: TMPE tool gets disabled when clicking on the button or on road tool.

LOG:
output_log.txt
TMPE.log

@kianzarrin
prevent double hot reload
5e98214 
prevent disableing tool after hot reload.
prevent uintentional disabling of other tools.
originalfoo
originalfoo requested changes Feb 22, 2020
View reviewed changes
TLM/TLM/TLM.csproj Outdated Show resolved Hide resolved
TLM/TLM/UI/UIBase.cs Outdated Show resolved Hide resolved
originalfoo
originalfoo reviewed Feb 22, 2020
View reviewed changes
TLM/TLM/TLM.csproj Outdated Show resolved Hide resolved
kvakvs
kvakvs approved these changes Feb 22, 2020
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor rename notes.

TLM/TLM/UI/ModUI.cs Outdated Show resolved Hide resolved
originalfoo
originalfoo approved these changes Feb 22, 2020
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kianzarrin kianzarrin merged commit 2c21127 into CitiesSkylinesMods:master Feb 22, 2020
@kianzarrin kianzarrin deleted the hot-reload-miniboost branch February 22, 2020 18:18
@originalfoo originalfoo added code cleanup Refactor code, remove old code, improve maintainability technical Tasks that need to be performed in order to improve quality and maintainability labels Feb 22, 2020
@originalfoo originalfoo added this to the 11.1.1 milestone Feb 22, 2020
@originalfoo originalfoo mentioned this pull request Feb 22, 2020
Closed
@originalfoo originalfoo added the performance Make it faster! label Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@originalfoo originalfoo originalfoo approved these changes

@krzychu124 krzychu124 Awaiting requested review from krzychu124

Assignees

@kianzarrin kianzarrin

Labels
code cleanup Refactor code, remove old code, improve maintainability performance Make it faster! technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
11.1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kianzarrin @kvakvs @originalfoo