dedicated turning lanes phase2

[kianzarrin]

fixes #567
dedicated turning lanes now has a state-machine of 2-states:

• 2 lanes: dedicated far turn | dedicated near turn
• 3+ lanes: favor left then forward | favor forward then left
• car+bus lanes: mix bus and car lanes | calculate bus arrows and car arrows separately (we can change this later in How to handle seperate turning lanes for a road with bus lanes? #752)

Notes:

• I moved code to dedicated UTIL class.
• I polished the code to use the same code path for near and far turns reducing code complexity.

Test:
I have tested it on 1 lanes 2 lanes and 3 lanes and 12 lane roads with and without bus lanes with and without left hand drive.

[originalfoo]

I have tested it on 1 lanes 2 lanes and 3 lanes and 12 lane roads

[originalfoo]

Ignore those two comments I added (now deleted) - had built the wrong PR, doh!!

[originalfoo]

Asymmetric roads, drive on left. This is the default vanilla state of the roads:

After Alt+Clicking each segment:

[kvakvs]

There are arcs of angles somewhere in our code, which correspond to arrow directions. I suggest someone find them, check whether they match what the game is using, and maybe move out somewhere to lane arrow manager.
Might be just inconsistent angle arcs.

[kvakvs]

Code's looking good.

[originalfoo]

Looks like this branch is based on 11.1.0 tag - can you rebase to master?

[originalfoo]

see comment above

[kianzarrin]

@aubergine10 @kvakvs I merged in the latest master version.

[originalfoo]

Note: Left Hand Traffic

issue 1 - wrong arrows

Vanilla:

Alt+Click segment in lane connector tool:

issue 2 - wrong arrows

Vanilla: 

Alt+Click:

issue 3 - segment selection

With this vanilla road, viewed from this camera angle, there was a selection dead-zone (indicated by red dashed area) where the mouse was not detecting the road.

If camera was rotated to pretty much any other angle, the road selection worked normally.

[kianzarrin]

issue 3 - segment selection
With this vanilla road, viewed from this camera angle, there was a selection dead-zone (indicated by red dashed area) where the mouse was not detecting the road.

I will check it out but most likely needs a issue with saved game and fixed camera attached to it (there is mod for that).
would be interesting to see if NetAdjust panel can hover the segment properly.

[kianzarrin]

I fixed the bug in my code. Now lane arrows should be right.

[kianzarrin]

issue 3 - segment selection
With this vanilla road, viewed from this camera angle, there was a selection dead-zone (indicated by red dashed area) where the mouse was not detecting the road.

@aubergine10 I didn't manage to reproduce this. Can you please create city with minimum test case and attach it to issue (please create new issue)

[originalfoo]

Testing again now....

If I manage to recreate issue 3 I'll try and create a save with vanilla + TMPE and nothing else and attach to new issue.

[originalfoo]

Tested in-game: It's working great now! And no recurrence of issue 3 either.

LGTM from end-user perspective! 👍

[kianzarrin]

This is ready for review.

[krzychu124]

Just little issues, but works great

[originalfoo]

@kvakvs can this be merged now?

outdated

[kvakvs]

i'm ok with that