Avoid null pointer exception in the UIScaler #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianzarrin
reviewed
Apr 13, 2020
TLM/TLM/U/UIScaler.cs
Outdated
| get { | ||
| UIView uiView = Singleton<UIView>.instance; | ||
| if (uiView != null) { | ||
| Camera uiCamera = uiView.uiCamera; |
There was a problem hiding this comment.
just a minor note. it would be more compact to write like this:
UIView uiView = Singleton<UIView>.instance;
Camera uiCamera = uiView?.uiCamera;
if(uiCamera !=null)
...There was a problem hiding this comment.
But this does not eliminate the null check, in your code null check will happen twice.
There was a problem hiding this comment.
yeah its the same code just more compact.
There was a problem hiding this comment.
Code compactness is nice, but not at the expense of obscuring clarity of intent of the code.
kianzarrin
approved these changes
Apr 13, 2020
krzychu124
requested changes
Apr 13, 2020
|
Pushed the suggested change. |
|
I'll see if this fixes any of the issues I'd been seeing in game. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #838
Bug
UIScalerwas usinguiCamera's pixel size, while eitherUIView.instanceorUIView.instance.uiCamerawas null. This is now cached and double checked.Potentially if UI never changes from 1920x1080, we can replace that entire code with a pair of
constSolution
A null check was added for both
UIView.instanceandUIView.instance.uiCamera, cached width and height are stored in case those are ever null.Also: Change to
WorldToScreenPointhas been reverted as it always been usingScreen.heightnot GUI height.