Dragging/sizing main menu pushes it back into screen rect

[kvakvs]

Fixes #848
Fixes #857

Minor modification addressing comment in #819 by @kianzarrin
Removed commented code which will never be used.

CHECKLIST

• Update tooltip for remaining sliders (one?)

[originalfoo]

Linked #848

[kvakvs]

Somehow the actual main menu never goes offscreen, even though i react on draghandle size going off screen, it is always entirely in-screen. I suspect its the dragging code in CO.UI which limits the window into the screen rect.

[originalfoo]

Making it go off-screen:

1. Set scaling factor small
2. Drag window to edge of screen
3. Increase scaling factor - top-left of menu stays in same place, but now it's bigger so some of it is off-screen

So maybe recheck bounds when scaling is changed?

Also, (I haven't tried this yet) what happens if menu is dragged towards bottom right of screen, then the screen resolution is reduced? Will it be completely off-screen?

[kvakvs]

If you drag to bottom right (i tried that), the main menu remains in GUI coordinate grid, which is always 1920x1080, so it does not move from the corner and is fully in screen.
And yes, i apply the clamp code to the main menu when UI scale changes.

[kianzarrin]

If you drag to bottom right (i tried that), the main menu remains in GUI coordinate grid,

Yes. I you want to push the GUI outside of screen you have to hack your way into it as aubergine explained.

And yes, i apply the clamp code to the main menu when UI scale changes.

Then why does it go outside of screen? maybe call refresh or invalidate or something. do you refresh absolute position?

[kianzarrin]

Can you call RefreshTooltip() on the sliders in the Options so that as the user moves the slider, the tooltip value gets updated.:

protected override void OnValueChanged() {
	base.OnValueChanged();
	tooltip = value.ToString();
	RefreshTooltip();
}

[kvakvs]

@kianzarrin addressed your list of forgotten commented fragments, they are removed
Thank you for that.
Also: Adding update tooltips and considering how to make this into every slider that we have. This works so well!

[kianzarrin]

thanks for removing the commented out code and cool sliders!

It does not push back the the main menu into screen:

[kvakvs]

The push logic only forces the label (and drag handle) to return back to the screen, not entire window.
The drag handle logic (C:S own code) seems to keep entire window in screen.
Can you make the drag handle off-screen at least partially?

[krzychu124]

👍

[originalfoo]

Loving the sliders updating their tooltips!

However, I was able to make the TMPE menu disappear in a non-recoverable fashion, although I'm not sure how many users will encounter this:

With the menu dragged to bottom right corner of screen, I changed from 16:9 2560x1440 resolution down to 4:3 640x480 resolution. Somewhat extreme (just to test), and obviously this isn't going to happen very often IRL. I didn't tested yet for less extreme aspect ratio and resolution changes.

However, some users with low spec systems often run on very low graphics most of the time, but then jump up to higher resolutions to take nice screenshots, so the issue described here it's not completely impossible to happen in the wild.

My suggestion is this - rather than trying to fix this extreme case, why not build a little "recovery mode" in to the main TMPE button?

Specifically:

Double click the 'crown button' to reset the toolbar position to 0, 0.

This way if we ever get users saying their toolbar disappeared, we can just reply "double click the tmpe button" (as that is usually still on screen based on past reports of missing toolbar).

[originalfoo]

See comment above.

[kvakvs]

Need to double check the assumption again: whether the GUI remains 1920x1080 units internally even when you change the aspect. In the code I assumed that it does. The facts might be telling otherwise.

[kianzarrin]

@kvakvs a bit outside of the scope of this review but there is only one slider left without the tooltip refresh and then we can close #857 that's the "dynamic lane selection" in GamePlay Tab

[kianzarrin]

Sorry I got a bit lost in the long conversations above. @kvakvs are you planning to push the whole window back into screen when the size gets larger. I have tracked the code and I can see you have observers that should push the window back into screen. but for some reason they don't. maybe put some breakpoints to see if the code is actually being executed?

[kvakvs]

The code is pushing the window back so that the handle becomes fully visible. Just what's necessary to drag the window. Does it actually work? I am not sure, all my screen resolutions had same aspect ratio and always 1920x1080 GUI resolution.

[originalfoo]

I think this only needs that slider tooltip refresh doing (DLS slider in gameplay tab iirc) then it is good to merge.

[originalfoo]

@kianzarrin What does that stuff above have to do with toolbar? Did you comment on the wrong PR?

[originalfoo]

LGTM 👍