Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SA1003 warnings #918

Merged
merged 1 commit into from
May 31, 2020
Merged

Fix SA1003 warnings #918

merged 1 commit into from
May 31, 2020

Conversation

DaEgi01
Copy link
Contributor

@DaEgi01 DaEgi01 commented May 31, 2020

Fixed 63 warnings with SA1003SymbolsMustBeSpacedCorrectly.
1 is still left, since its inside a #ifdef :/

originalfoo
originalfoo approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@originalfoo originalfoo added the code cleanup Refactor code, remove old code, improve maintainability label May 31, 2020
@originalfoo originalfoo added this to the 11.6.0 milestone May 31, 2020
@DaEgi01 DaEgi01 merged commit f13ed26 into master May 31, 2020
@DaEgi01 DaEgi01 deleted the WarningsSA1003 branch May 31, 2020 23:59
@originalfoo originalfoo changed the title Fixed SA1003SymbolsMustBeSpacedCorrectly warnings. Fixed SA1003 SymbolsMustBeSpacedCorrectly warnings. Jun 1, 2020
@originalfoo originalfoo changed the title Fixed SA1003 SymbolsMustBeSpacedCorrectly warnings. Fix SA1003 warnings Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@originalfoo originalfoo originalfoo approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

Assignees

@DaEgi01 DaEgi01

Labels
code cleanup Refactor code, remove old code, improve maintainability
Projects
None yet
Milestone
11.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DaEgi01 @originalfoo @krzychu124