Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SA1117 warnings #926

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Fix SA1117 warnings #926

merged 3 commits into from
Jun 9, 2020

Conversation

DaEgi01
Copy link
Contributor

@DaEgi01 DaEgi01 commented Jun 9, 2020 •
edited by originalfoo

Fix SA1117 warnings - All params either on one line or separate lines

@DaEgi01
Fixed 139 'SA1117 All method parameters must be placed on the same li…
0849bf4 
…ne, or each parameter must be placed on a separate line.' warnings.
@DaEgi01
Fixed 'SA1117 All method parameters must be placed on the same line, …
a4ef2b9 
…or each parameter must be placed on a separate line.' warnings.
@DaEgi01
Copy link
Contributor Author

DaEgi01 commented Jun 9, 2020

whops .. still an issue to fix.

originalfoo
originalfoo approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@originalfoo originalfoo changed the title Fix the1117 warnings Fix SA1117 warnings - All params either on one line or separate lines Jun 9, 2020
@originalfoo originalfoo added the code cleanup Refactor code, remove old code, improve maintainability label Jun 9, 2020
@originalfoo originalfoo added this to the 11.6.0 milestone Jun 9, 2020
@DaEgi01 DaEgi01 merged commit 66918bb into master Jun 9, 2020
@DaEgi01 DaEgi01 deleted the FixThe1117Warnings branch June 9, 2020 21:16
@originalfoo originalfoo changed the title Fix SA1117 warnings - All params either on one line or separate lines Fix SA1117 warnings Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@originalfoo originalfoo originalfoo approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

Assignees

@DaEgi01 DaEgi01

Labels
code cleanup Refactor code, remove old code, improve maintainability
Projects
None yet
Milestone
11.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DaEgi01 @originalfoo @krzychu124