Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SA1201 warnings #927

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Fix SA1201 warnings #927

merged 2 commits into from
Jun 9, 2020

Conversation

DaEgi01
Copy link
Contributor

@DaEgi01 DaEgi01 commented Jun 9, 2020

Fixed all SA1201 A "constructor" should not follow a XYZ warnings for a start.

@originalfoo originalfoo added the code cleanup Refactor code, remove old code, improve maintainability label Jun 9, 2020
@originalfoo originalfoo added this to the 11.6.0 milestone Jun 9, 2020
originalfoo
originalfoo approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@originalfoo originalfoo requested a review from a team June 9, 2020 23:48
krzychu124
krzychu124 approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DaEgi01 DaEgi01 merged commit a7ccdfc into master Jun 9, 2020
@DaEgi01 DaEgi01 deleted the FixWarnings_SA1201 branch June 9, 2020 23:52
@originalfoo originalfoo changed the title Fix warnings sa1201 Fix SA1201 warnings Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@originalfoo originalfoo originalfoo approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

Assignees

@DaEgi01 DaEgi01

Labels
code cleanup Refactor code, remove old code, improve maintainability
Projects
None yet
Milestone
11.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DaEgi01 @originalfoo @krzychu124