Fix IDE0003 warnings #940
Merged
Fix IDE0003 warnings #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is.xyz notation for fields. Fixed all other cases for methods, props and events.
…is.xyz notation for fields. Fixed all other cases for methods, props and events.
DaEgi01
added
the
code cleanup
originalfoo
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
LGTM 👍
Tagging closed PR for ref of earlier discussion: #931
krzychu124
approved these changes
Jun 11, 2020
|
So @DaEgi01 you removed warnings and still butchered my modules :) I am moderately unhappy. |
|
@kvakvs whaa what happened? where was the butchering? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed warnings for fields from the ruleset since some of us like this.xyz notation for fields.
Fixed all other cases for methods, props and events.