Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record vehicle restrictions #966

Merged
merged 5 commits into from
Oct 4, 2020
Merged

Conversation

kianzarrin
Copy link
Collaborator

@kianzarrin kianzarrin commented Jun 28, 2020

Added record for vehicle restriction.

I added 2 methods to the vehicle restriction manager to be able to clear vehicle restrictions for a lane and to be able to understand if vehicle restriction data is empty in which case I don't store anything.

Test:

use one of the following methods:
A) You can also test this by using the clear/undo button from the road selection panel:

  • set up vehicle restrictions
  • use the clear button to clear traffic rules
  • make sure vehicle restrictions are cleared
  • Press the clear button again to UNDO traffic rules.
  • Expected result: Vehicle restrictions are back up

B) put vehicle restrictions in the asset interchange editor and place them in-game

C) use move it mod to copy vehicle restriction. this intermediate version of moveIt is suitable for this review:

Screenshot (1137)

@kianzarrin kianzarrin changed the title 959 record vehicle restrictions0 record vehicle restrictions Jun 29, 2020
@kianzarrin kianzarrin self-assigned this Jun 29, 2020
@kianzarrin kianzarrin added serialization load/store data in memory or on disk EXTERNAL Mod conflict or other external factor labels Jun 29, 2020
@kianzarrin kianzarrin added this to the 11.6.0 milestone Jun 29, 2020
@kianzarrin kianzarrin requested a review from DaEgi01 June 29, 2020 14:55
@kianzarrin kianzarrin mentioned this pull request Jul 7, 2020
@originalfoo
Copy link
Member

move it mod can copy-paste TMPE data. (I am using a version of MoveIT that is not yet released).

Is the unreleased version available somewhere? (or link to tagged commit so we can build from source)

You can also test this by using the clear button from the road selection panel

How does that test whether the vehicle restrictions were recorded?

@kianzarrin
Copy link
Collaborator Author

@aubergine10 Is the unreleased version available somewhere? (or link to tagged commit so we can build from source)

https://github.com/Quboid/CS-MoveIt/files/4805542/MoveIt.zip

How does that test whether the vehicle restrictions were recorded?

If you press clear, it removes exisiting Vehicle restrictions. if you press it again, it undo's them. they can only be undone if they were recorded.

Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, also works in game. 👍
I didn't noticed any weird entries/errors in the log also.

Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works flawless for me. Code looks okay too.

@kianzarrin kianzarrin merged commit 3698066 into master Oct 4, 2020
@kianzarrin kianzarrin deleted the 959-record-vehicle-restrictions0 branch October 4, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EXTERNAL Mod conflict or other external factor serialization load/store data in memory or on disk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants