Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

post build script to create mdb file for file and line numbers #973

Merged
merged 9 commits into from
Jul 15, 2020
Merged

post build script to create mdb file for file and line numbers #973

merged 9 commits into from
Jul 15, 2020

Conversation

kianzarrin
Copy link
Collaborator

@kianzarrin kianzarrin commented Jul 7, 2020 •
edited

In https://github.com/kianzarrin/PedestrianBridge/issues/7 I have explained how to print out file and line numbers of stack trace to output log.

in this review, I generate the MDB file in the post-build script.

  • locate unity install dir
  • generate mdb file using pdb2mdb.exe
  • copy mdb file to mod folder

Requirement:

  • Unity 5.6.7 installation to generate the mdb file.
  • if unity is not installed in program files, create a symlink to it.
  • replace CO dll to see the file and line numbers.

PS: I think we should upload mdb file to the workshop so pro users would be able to generate file and line numbers in their logs.

@kianzarrin kianzarrin changed the title post build script creates mdb file for file and line numbers post build script to create mdb file for file and line numbers Jul 7, 2020
dymanoid
dymanoid suggested changes Jul 8, 2020
View reviewed changes
docs/Debug_Symbols.md Outdated Show resolved Hide resolved
docs/Debug_Symbols.md Outdated Show resolved Hide resolved
docs/Debug_Symbols.md Outdated Show resolved Hide resolved
kianzarrin and others added 3 commits July 9, 2020 19:09
@kianzarrin @dymanoid
Update docs/Debug_Symbols.md
af8de07 
Co-authored-by: dymanoid <9433345+dymanoid@users.noreply.github.com>
@kianzarrin @dymanoid
Update docs/Debug_Symbols.md
61979b1 
Co-authored-by: dymanoid <9433345+dymanoid@users.noreply.github.com>
@kianzarrin @dymanoid
Update docs/Debug_Symbols.md
65138a4 
Co-authored-by: dymanoid <9433345+dymanoid@users.noreply.github.com>
@kianzarrin kianzarrin requested a review from dymanoid July 9, 2020 16:11
@kianzarrin
Copy link
Collaborator Author

Thanks dynamoid for the change suggestion. Does the code look good?

@originalfoo originalfoo added docs Documentation technical Tasks that need to be performed in order to improve quality and maintainability labels Jul 10, 2020
@originalfoo originalfoo added this to the 11.6.0 milestone Jul 10, 2020
@kianzarrin kianzarrin merged commit d7e7159 into master Jul 15, 2020
@kianzarrin kianzarrin deleted the file-line branch July 15, 2020 05:50
@originalfoo originalfoo mentioned this pull request Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@originalfoo originalfoo originalfoo approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

@DaEgi01 DaEgi01 Awaiting requested review from DaEgi01

@kvakvs kvakvs Awaiting requested review from kvakvs

@dymanoid dymanoid Awaiting requested review from dymanoid

Assignees

@kianzarrin kianzarrin

Labels
docs Documentation technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
11.6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kianzarrin @originalfoo @dymanoid @krzychu124