Lane connection overlay and performance improvements

[krzychu124]

Closes #282
Fixes #654

• more accurate lane connection arcs
• performance improvements by decreasing render box height to minimum value
• variable line visibility through objects, depends on intersection position (above/under ground)

Accurate arcs:

No overdraw below road:

Overdraw when underground connection (to be changed):

Issue 1 - circles at ground level, but lane connections on road level

Issue 2 - underground connections visible in non-underground mode

Issue 3 (another PR?) issue with intersection circles - I need to click on road level, not on circle to enable edit mode

Questions:

What should we do with overlay of underground lane connections?
Hide by default and assign new button (which one) to show underground connections on demand?
Turn visibility on, automatically when camera is in Underground mode?
Maybe hide non-underground by default and invert Show on demand button action from previous question?

What to do with markers and lane previews? Should I also decrease render box height to minimum value?

To do list:

• add reliable function to detect current camera view (over/underground) - camera InfoView.None/InfoView.Traffic
• correct node marker position (3d space - minimal overdraw)
• correct lane connector marker position (3d space - minimal overdraw)
• when overground, disable interactions and make underground lane connections semi-transparent (invert colors. maybe change thickness - need check what looks best)
• fix calculation of lane markers height
• fix mouse interactions for underground connections

Low priority (nice to have):

• change cursor on hover above disabled node - add tooltip info?

Latest build of this PR is available here
No need to build it manually if you want to try it live

[kvakvs]

Nice

[originalfoo]

Maybe some indented options in mod options > overlays > lane connectors?

• Filter based on above/below ground view

Render height on lanes (lower is faster): (slider)

[krzychu124]

I need more feedback what to do with underground overlays. Please try it in the game and you will see where is the problem now.

[kvakvs]

Do not use projection textures when rendering underground, draw in 3d space where the junction should be.
Make underground not editable and look different from overground. When the user switches to white underground view, let them edit the underground and make overground not editable and look different.
Lane connectors could also look different like thin hint lines, not projected but rendered in 3d space?

[krzychu124]

Yup, that's the plan.
Height of intersection marker is ok, but I noticed that height of markers (lane connectors) is completely wrong - they position was calculated at ~1/4 of distance between terrain level and expected underground position, so I have to fix that first.
I'll create a checklist :)

[kianzarrin]

[medium priority UI issue]
there is difference between rendered node and select-able node

(my cursor over the top node)

[kianzarrin]

I can't select under ground node if there is an over ground road passing by.
over ground roads should be ignored in underground view.

I am not sure if this is withing the scope of this PR. if it is not please create/reference issue.

[krzychu124]

Interesting cases, I'll check why it does not work 🤔

[kianzarrin]

see comments above

[krzychu124]

@kianzarrin
I fixed multiple issues with overlays and lane ray casting underground and elevated roads and improved accuracy.

Minor thing but acceptable: rendered underground lane overlay does not match segment shape (although ray casting is accurate), it always render bezier on the same height (lowest Y of bezier) - that's shader limitation for underground rendering 🙁

With regards to hovered node detection it should work slightly better now but I'll create new issue because to completely fix that we need to build custom ray caster with features like ignoring segments or nodes based on selected mode.
Default tool ray caster is pretty limited in that matter.

[kianzarrin]

Default tool ray caster is pretty limited in that matter.

the bulldoze tool does not seem to suffer from this problem.

[kianzarrin]

what is the deal with that node in the center of the train station?

[kianzarrin]

OK I will look more into this.

[kianzarrin]

why are you using ray-caster from default tool? didn't we wrote our own ray-caster?

[krzychu124]

what is the deal with that node in the center of the train station?

I didn't change anything with regards to detecting which node overlay should be shown (only removed those from dead-ends). I'll check what rules are set there.

why are you using ray-caster from default tool? didn't we wrote our own ray-caster?

We didn't write own ray-caster, you've just added few hacks to correctly detect clicks on the terrain if node/segment is underneath. I don't need that code anymore since I'm rendering overlays where they should be and I don't need default ray-caster for that.

The only problem with ray-caster is detection of which node is hovered when ray intersects with other segments or nodes which we want to ignore. It's not game breaking problem because you can move camera. Probability that users will be changing lane connections underground is pretty low. Most of the times you click on the node and then use "stay-in-lane" feature.

[chameleon-tbn]

ingamte tests:

150 mods
12k assets

All standard stuff seems to work as it should :) Faster... hmmm i can't say... maybe my system is just too powerful ;)