Fix bug and add a method to simplify name showing

CitizensDev · Apr 17, 2022 · f4e3786 · f4e3786
1 parent da76924
commit f4e3786
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/main/src/main/java/net/citizensnpcs/trait/ArmorStandTrait.java b/main/src/main/java/net/citizensnpcs/trait/ArmorStandTrait.java
@@ -135,6 +135,11 @@ public void setAsPointEntity() {
         npc.data().set(NPC.NAMEPLATE_VISIBLE_METADATA, false);
     }
 
+    public void setAsPointEntityWithName() {
+        setAsPointEntity();
+        npc.data().set(NPC.NAMEPLATE_VISIBLE_METADATA, true);
+    }
+
     /**
      * @see ArmorStand#setGravity(boolean)
      */

diff --git a/main/src/main/java/net/citizensnpcs/trait/HologramTrait.java b/main/src/main/java/net/citizensnpcs/trait/HologramTrait.java
@@ -73,8 +73,7 @@ public void clear() {
     private NPC createHologram(String line, double heightOffset) {
         NPC hologramNPC = registry.createNPC(EntityType.ARMOR_STAND, line);
         hologramNPC.addTrait(new ClickRedirectTrait(npc));
-        hologramNPC.getOrAddTrait(ArmorStandTrait.class).setAsPointEntity();
-        npc.data().set(NPC.NAMEPLATE_VISIBLE_METADATA, true);
+        hologramNPC.getOrAddTrait(ArmorStandTrait.class).setAsPointEntityWithName();
         hologramNPC.spawn(currentLoc.clone().add(0,
                 getEntityHeight()
                         + (direction == HologramDirection.BOTTOM_UP ? heightOffset : getMaxHeight() - heightOffset),