Changes to world unloading

CitizensDev · Apr 14, 2013 · fc53c6e · fc53c6e
1 parent 14144dd
commit fc53c6e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/main/java/net/citizensnpcs/EventListen.java b/src/main/java/net/citizensnpcs/EventListen.java
@@ -252,10 +252,15 @@ public void onWorldUnload(WorldUnloadEvent event) {
         for (NPC npc : getAllNPCs()) {
             if (!npc.isSpawned() || !npc.getBukkitEntity().getWorld().equals(event.getWorld()))
                 continue;
-            storeForRespawn(npc);
-            npc.despawn(DespawnReason.WORLD_UNLOAD);
-            if (event.isCancelled())
+            boolean despawned = npc.despawn(DespawnReason.WORLD_UNLOAD);
+            if (event.isCancelled() || !despawned) {
+                for (ChunkCoord coord : toRespawn.keySet()) {
+                    if (event.getWorld().getName().equals(coord.worldName))
+                        respawnAllFromCoord(coord);
+                }
                 return;
+            }
+            storeForRespawn(npc);
             Messaging.debug("Despawned", npc.getId() + "due to world unload at", event.getWorld().getName());
         }
     }

diff --git a/src/main/java/net/citizensnpcs/npc/ai/MCTargetStrategy.java b/src/main/java/net/citizensnpcs/npc/ai/MCTargetStrategy.java
@@ -96,7 +96,7 @@ public void stop() {
 
     @Override
     public boolean update() {
-        if (target == null || target.dead) {
+        if (target == null || !target.getBukkitEntity().isValid()) {
             cancelReason = CancelReason.TARGET_DIED;
             return true;
         }