Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9454: Fix address search caching for translated entities [part 2] #165

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Dec 18, 2023

UHF-9454

What was done

  • Fix address search caching for translations. There was an attempt to fix this earlier, but it did not work for translated content.

From #helfi_kuuma_linja

Ruotsin- ja englanninkielisillä hakusivuilla (linkit alla) virhe on vielä siten, että kaikissa tuloskorteissa ei näy etäisyys annettuun osoitteeseen. Suomenkielisessä haussa näyttäisi toimivan.
https://www.hel.fi/sv/fostran-och-utbildning/grundlaggande-utbildning/morgon-och-e[…]lorna/eftermiddagsverksamhet/platser-med-eftermiddagsverksamhet
https://www.hel.fi/en/childhood-and-education/basic-education/morning-and-after-sc[…]hobbies/after-school-activities/after-school-activity-locations (edited)

How to install

  • Make sure your KASKO is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi tpr
    • composer require drupal/helfi_tpr:dev-UHF-9454-address-search-caching
  • Run make drush-updb drush-cr

How to test

Other PRs

@hyrsky hyrsky force-pushed the UHF-9454-address-search-caching branch from b40a699 to e16a6b9 Compare December 18, 2023 08:27
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one fixed the issue for me 🦖

@hyrsky hyrsky force-pushed the UHF-9454-address-search-caching branch from 5962656 to 324b586 Compare December 19, 2023 09:40
@hyrsky hyrsky force-pushed the UHF-9454-address-search-caching branch from 324b586 to 215ec59 Compare December 19, 2023 09:48
Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants