Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9454: Fix caching issue in address search #164

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Dec 7, 2023

UHF-9454

What was done

  • Issue from #kuuma_linja: after-school activity search results contain cached distances.

How to install

  • Make sure your KASKO instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the TPR module
    • composer require drupal/helfi_tpr:dev-UHF-X-address-search-caching
  • Make sure that your settings.local.php and *.services.yml do not override default cache settings.
  • Run make drush-updb drush-cr

How to test

Copy link

sonarcloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5987e30) 81.63% compared to head (97c8e1b) 81.63%.

❗ Current head 97c8e1b differs from pull request most recent head 31f7b08. Consider uploading reports for the commit 31f7b08 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #164   +/-   ##
=========================================
  Coverage     81.63%   81.63%           
  Complexity      361      361           
=========================================
  Files            50       50           
  Lines          2881     2881           
=========================================
  Hits           2352     2352           
  Misses          529      529           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr 🪨 s!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants