Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8908: Convert email field type to email #171

Merged
merged 6 commits into from
Mar 21, 2024
Merged

UHF-8908: Convert email field type to email #171

merged 6 commits into from
Mar 21, 2024

Conversation

tuutti
Copy link
Member

@tuutti tuutti commented Mar 20, 2024

How to install

  • composer require drupal/helfi_tpr:dev-UHF-8908
  • composer require drupal/helfi_api_base:dev-UHF-8908

How to test

  • Run drush updb
  • Re-run TPR unit and service channel migrate: drush migrate:import tpr_unit, drush migrate:import tpr_service_channel
  • Make sure email field is populated

Other PRs

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.68%. Comparing base (44f69ad) to head (3a22787).

❗ Current head 3a22787 differs from pull request most recent head ac2532c. Consider uploading reports for the commit ac2532c to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #171      +/-   ##
============================================
+ Coverage     81.65%   81.68%   +0.03%     
- Complexity      361      362       +1     
============================================
  Files            50       50              
  Lines          2883     2888       +5     
============================================
+ Hits           2354     2359       +5     
  Misses          529      529              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked after running the migrations with --update flag 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants