Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tests for age filter and similar events #160

Merged
merged 4 commits into from
Jan 18, 2023
Merged

fix: tests for age filter and similar events #160

merged 4 commits into from
Jan 18, 2023

Conversation

melniiv
Copy link
Contributor

@melniiv melniiv commented Jan 17, 2023

Description

Issues

Closes

DEV-XXX:

Related

Testing

Automated tests

Manual testing

Screenshots

Additional notes

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr160.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://harrastukset-pr160.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr160.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://harrastukset-pr160.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr160.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://harrastukset-pr160.dev.hel.ninja 😆🎉🎉🎉

@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

Hobbies-Helsinki branch is deployed to platta: https://harrastukset-pr160.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://harrastukset-pr160.dev.hel.ninja 😆🎉🎉🎉

nikomakela
nikomakela approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@nikomakela nikomakela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seems to work. I don't fully understand the changes that are done. Was the problem really in the actual queries and not in the test mocks? What I was waiting from this PR was some changes to the mocks.

@nikomakela nikomakela mentioned this pull request Jan 18, 2023
Closed
@nikomakela nikomakela self-requested a review January 18, 2023 09:28
nikomakela
nikomakela requested changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@nikomakela nikomakela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ages should not be hard coded to the query. Instead, the test mocks should be fixed.

@melniiv melniiv merged commit 20362e1 into main Jan 18, 2023
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Merged
@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Closed
@github-actions github-actions bot mentioned this pull request Mar 30, 2023
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomakela nikomakela nikomakela approved these changes

@kristianjokela kristianjokela Awaiting requested review from kristianjokela

@karisal-anders karisal-anders Awaiting requested review from karisal-anders

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@melniiv @terovirtanen @nikomakela @karisal-anders