TIED-46: Add & configure code quality tools (black, isort, flake8), add pre-commit configuration #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charn
reviewed
Feb 16, 2023
danipran
force-pushed
the
TIED-46-add-code-quality-tools
branch
from
3d4769b
to
03f0dc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add & configure black, isort and flake8, add optional pre-commit configuration. Also delete
setup.cfg(contents moved to.flake8andpyproject.toml) and.travis.yml(not used anymore).The versions for the tools are a bit old, due to the project using Python 3.6 and it not being supported by them anymore.
Will create a separate PR for the output of black/isort/flake8.