-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIED-73 | Create a production ready container #352
Conversation
00bb9a5
to
84ed00d
Compare
Codecov Report
@@ Coverage Diff @@
## main #352 +/- ##
=======================================
Coverage 93.89% 93.89%
=======================================
Files 149 149
Lines 5468 5472 +4
=======================================
+ Hits 5134 5138 +4
Misses 334 334
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets debate the get_finnish_analyzer()
a bit more, my spider senses are tingling on that one.
84ed00d
to
690372a
Compare
690372a
to
63940d0
Compare
Run backend with uWSGI on production mode without development requirements. - Move dev-requirement* -> requirements-dev* - Add uwsgi to requirements - Add uWSGI configuration - Run uWSGI from docker-entrypoint.sh - Add staticbuilder and production stages to the Dockerfile - Add ELASTICSEARCH_ANALYZER_MODE setting mainly for avoiding an error when collectstatic failed due to elasticsearch connection error. - compose.yml use development image and make django depend on elasticsearch Refs TIED-73
2b743b7
to
05df603
Compare
Refs TIED-73
- Change isort url in pre-commit config - Remove requirement for a specific python minor version Refs TIED-73
e761165
to
b4394d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Replace createsuperuser in docker-entrypoint.sh with the new add_admin_user command. Default createsuperuser fails if user already exists. Refs TIED-73
b4394d5
to
2f847a2
Compare
Kudos, SonarCloud Quality Gate passed! |
Run backend with uWSGI on production mode without development requirements.
dev-requirement*
->requirements-dev*
uwsgi
to requirementsdocker-entrypoint.sh
staticbuilder
andproduction
stages to theDockerfile
ELASTICSEARCH_ANALYZER_MODE
setting mainly for avoiding an error whencollectstatic
failed due to elasticsearch connection error.compose.yml
use development image and make django depend on elasticsearchAlso this PR replaces
createsuperuser
indocker-entrypoint.sh
with a newadd_admin_user
command. Django'screatesuperuser
fails if user already exists.