Update workflow to use elasticsearch with raudikko #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
voneiden
commented
Apr 4, 2023
•
voneiden
commented
- Workflow updated to support elasticsearch with raudikko (using docker compose)
- Pytest configuration updated to use a test_settings.py file and override the test index names
- Made conditional voikko tests as non-conditional tests. Rationale is that I'd rather have tests fail than be skipped.
Codecov Report
@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 93.91% 94.32% +0.40%
==========================================
Files 151 152 +1
Lines 5509 5514 +5
==========================================
+ Hits 5174 5201 +27
+ Misses 335 313 -22
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
voneiden
force-pushed
the
tied-76-raudikko-tweaks
branch
2 times, most recently
from
02f7552
to
02050b2
Compare
voneiden
force-pushed
the
tied-76-raudikko-tweaks
branch
from
8112d0b
to
c21bd51
Compare
|
Kudos, SonarCloud Quality Gate passed! |
charn
reviewed
Apr 5, 2023
| @@ -21,9 +21,7 @@ def test_classification_search_exact(user_api_client, classification): | |||
|
|
|||
|
|
|||
| @pytest.mark.django_db | |||
| def test_classification_search_fuzzy1(user_api_client, es_connection, classification): | |||
| if "voikko" not in str(es_connection.indices.get_settings()): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.