Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commitlint config #383

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Update commitlint config #383

merged 1 commit into from
Mar 26, 2024

Conversation

tuomas777
Copy link
Contributor

@tuomas777 tuomas777 commented Mar 25, 2024

Updated commitlint config to match Ratkaisutoimisto's new conventions:

  • added deps as an allowed commit type
  • started using JSON config file .commitlintrc.json instead of Javascript commitlint.config.js

Refs: RAT-150

@terovirtanen
Copy link
Contributor

TIEDONOHJAUS-API branch is deployed to platta: https://tiedonohjaus-pr383.api.dev.hel.ninja 🚀🚀🚀

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.31%. Comparing base (f038832) to head (3ddeb17).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files         105      105           
  Lines        5061     5061           
=======================================
  Hits         4824     4824           
  Misses        237      237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Updated commitlint config to match Ratkaisutoimisto's new conventions:

* added `deps` as an allowed commit type
* started using JSON config file `.commitlintrc.json` instead of
  Javascript `commitlint.config.js`
Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

TIEDONOHJAUS-API branch is deployed to platta: https://tiedonohjaus-pr383.api.dev.hel.ninja 🚀🚀🚀

@tuomas777 tuomas777 requested a review from a team March 25, 2024 17:12
Copy link
Contributor

@charn charn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 :shipit:

@tuomas777 tuomas777 merged commit a735e9f into main Mar 26, 2024
23 checks passed
@tuomas777 tuomas777 deleted the commitlint-config-update branch March 26, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants