Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDS-2102: login data to cookie docs #1252

Merged
merged 3 commits into from
May 7, 2024

Conversation

NikoHelle
Copy link
Contributor

@NikoHelle NikoHelle commented Apr 4, 2024

No code changes, reviewable by anyone!

Description

The login component stores data to session storage. That data should also be listed in the common cookie consents.

Added information about the stored data common cookies and to the docs.

Related Issue

Closes HDS-2102

How Has This Been Tested?

Storybook and docs site tested locally.

Docs demo of the part added to the login component docs.

Docs demo of the cookie pattern where Login component data is listed with other cookie consents.

Storybook demo how consents are listed. Open the "Necessary cookies" > "Login"

Screenshots (if appropriate):

How the new data is shown in the modal:

image

Add to changelog

  • Added needed line to changelog

Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tässä käännöksiä

},
sv: {
hostName: currentSiteTranslations.sv,
description: '(SV) Käyttäjän kirjautumistiedot tallennetaan selaimen muistiin (session storage).',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Användarens inloggningsuppgifter lagras i webbläsarens minne (session storage).

name: 'hds_login_api_token_storage_key',
fi: {
hostName: currentSiteTranslations.fi,
description: 'Kirjautuneen käyttäjän api tokenit tallennetaan selaimen muistiin (session storage).',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kirjautuneen käyttäjän rajanpinta-avaimet (api tokens) tallennetaan selaimen muistiin (session storage).

},
sv: {
hostName: currentSiteTranslations.sv,
description: '(SV) Kirjautuneen käyttäjän api tokenit tallennetaan selaimen muistiin (session storage).',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Api-token för en autentiserad användare sparas i webbläsarens minne (session storage).

fi: {
hostName: currentSiteTranslations.fi,
description:
'Kirjautuneen käyttäjän access token tallennetaan selaimen muistiin (session storage), jolla tunnistetaan kenen api tokenit ovat tallessa.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kirjautuneen käyttäjän pääsyoikeudet tallennetaan selaimen muistiin, jotta tunnistetaan kenen rajapinta-avaimet on tallessa.

sv: {
hostName: currentSiteTranslations.sv,
description:
'(SV) Kirjautuneen käyttäjän access token tallennetaan selaimen muistiin (session storage), jolla tunnistetaan kenen api tokenit ovat tallessa.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Den inloggade användarens åtkomsträttigheter lagras i webbläsarens minne för att identifiera vems token som lagras.

@@ -92,6 +92,11 @@ export function getCookieContent() {
const tunnistamoUrl = 'api.hel.fi';
const keycloakUrl = 'tunnistus.hel.fi';
const suomiFiUrl = 'suomi.fi';
const currentSiteTranslations = {
fi: 'Tämä sivusto',
sv: '(SV) Tämä sivusto',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denna webbsida

@NikoHelle NikoHelle marked this pull request as ready for review April 17, 2024 10:54
@NikoHelle NikoHelle changed the title (needs translations) HDS-2102: login data to cookie docs HDS-2102: login data to cookie docs Apr 17, 2024
@laurakarhu laurakarhu requested review from a team April 23, 2024 08:49
Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@laurakarhu laurakarhu added this to the HDS 3.8.0 milestone Apr 23, 2024
Copy link
Contributor

@mrTuomoK mrTuomoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@NikoHelle NikoHelle force-pushed the hds-2102-login-cookie-docs branch from 02e7684 to fef0c6b Compare May 7, 2024 06:43
Copy link

github-actions bot commented May 7, 2024

Test Results

1 tests   1 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit fef0c6b.

@NikoHelle NikoHelle merged commit ec625c2 into development May 7, 2024
9 checks passed
@NikoHelle NikoHelle deleted the hds-2102-login-cookie-docs branch May 7, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants