Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dual support tunnistamo/keycloak in authorization field #470

Merged
merged 4 commits into from Jan 4, 2024

Conversation

voneiden
Copy link
Contributor

@voneiden voneiden commented Jan 2, 2024

No description provided.

@terovirtanen
Copy link
Contributor

KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀

@voneiden voneiden requested a review from a team January 3, 2024 07:44
Hardcode keycloak style scopes in gdpr tests since that's what we will
 be using in prod.
@voneiden voneiden force-pushed the tweak-oidc branch 2 times, most recently from cc99e33 to e53a794 Compare January 3, 2024 12:41
@voneiden
Copy link
Contributor Author

voneiden commented Jan 3, 2024

Ok, I've added a new test_settings.py which allows extending the normal KK settings and configured pytest to use it. Related PR on Azure where I remove the OIDC variables and DJANGO_SETTINGS_MODULE (since it most certainly should come through setup.cfg)

https://dev.azure.com/City-of-Helsinki/kerrokantasi/_git/kerrokantasi-pipelines/pullrequest/7452

@terovirtanen
Copy link
Contributor

KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀

Copy link
Contributor

@tuomas777 tuomas777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@terovirtanen
Copy link
Contributor

KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀

Due to the way the regular settings are made, test_settings also relies
 on the use of globals() to update the settings.
@terovirtanen
Copy link
Contributor

KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀

These used to be required with Tunnistamo, but kKeycloak based
authentication does not normally use API scopes.
@terovirtanen
Copy link
Contributor

KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀

Copy link

sonarcloud bot commented Jan 3, 2024

@voneiden voneiden merged commit 620ad7a into master Jan 4, 2024
22 checks passed
@voneiden voneiden deleted the tweak-oidc branch January 4, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants