New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: dual support tunnistamo/keycloak in authorization field #470
Conversation
KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀 |
KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀 |
KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀 |
KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀 |
KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀 |
Hardcode keycloak style scopes in gdpr tests since that's what we will be using in prod.
cc99e33
to
e53a794
Compare
Ok, I've added a new test_settings.py which allows extending the normal KK settings and configured pytest to use it. Related PR on Azure where I remove the OIDC variables and DJANGO_SETTINGS_MODULE (since it most certainly should come through setup.cfg) https://dev.azure.com/City-of-Helsinki/kerrokantasi/_git/kerrokantasi-pipelines/pullrequest/7452 |
KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀 |
KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀 |
Due to the way the regular settings are made, test_settings also relies on the use of globals() to update the settings.
KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀 |
These used to be required with Tunnistamo, but kKeycloak based authentication does not normally use API scopes.
KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr470.api.dev.hel.ninja 🚀🚀🚀 |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
No description provided.