Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KER-280 | GDPR additions and changes #480

Merged
merged 4 commits into from Feb 20, 2024
Merged

Conversation

nicobav
Copy link
Contributor

@nicobav nicobav commented Feb 16, 2024

Adds following changes to gdpr api get

  • Show (soft)deleted comments
  • Renders file and image urls instead of bytes
    • Added custom middleware for accessing the request so that the url could be built.

Refs KER-280

Adds deleted section comments to the gdpr get data.

Refs KER-280
@nicobav nicobav requested a review from a team February 16, 2024 13:22
In gdpr api we need to render the file urls so we need the request for
it.
Adds CurrentRequestMiddleware which stores the request object to thread
and removes it at the end of request.

Refs KER-280
@terovirtanen
Copy link
Contributor

KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr480.api.dev.hel.ninja 🚀🚀🚀

There's a CurrentRequestMiddleware which stores the current request.
This adds util function for using it

Refs KER-280
Adds mixin class for constructing the file or image url and use it in
image and file models.
This result the gdpr api having url to the file instead of bytes
representation.

Refs KER-280
Copy link

sonarcloud bot commented Feb 20, 2024

@terovirtanen
Copy link
Contributor

KERROKANTASI-API branch is deployed to platta: https://kerrokantasi-pr480.api.dev.hel.ninja 🚀🚀🚀

Copy link
Contributor

@charn charn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 :shipit:

@nicobav nicobav merged commit d76d504 into master Feb 20, 2024
23 checks passed
@nicobav nicobav deleted the KER-280/gdpr-api-changes branch February 20, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants