Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINK-1847 | Use event start time for signup birth of date validation #312

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Jan 16, 2024

Description

  • Allow user to signup if user is old enough in the event start time
  • Prevent user to signup if user is too old in the event start time

Closes

LINK-1847

- Allow user to signup if user is old enough in the event start time
- Prevent user to signup if user is too old in the event start time
@jorilindell jorilindell requested review from harriris-vincit and a team January 16, 2024 10:37
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5d712e) 99.72% compared to head (9bd2e6d) 99.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #312   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files         568      568           
  Lines        9441     9448    +7     
  Branches     2061     2063    +2     
=======================================
+ Hits         9415     9422    +7     
  Misses         23       23           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent to me 👍

@jorilindell jorilindell merged commit 20f0008 into main Jan 16, 2024
2 of 4 checks passed
@jorilindell jorilindell deleted the fix/LINK-1847-date-of-birth-validation branch January 16, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants