LINK-1891 | Fix failing tests #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr330-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is failed for https://linkedcomponents-pr330-ui.dev.hel.ninja 😿💢💥💥 |
1 similar comment
e2e tests result is failed for https://linkedcomponents-pr330-ui.dev.hel.ninja 😿💢💥💥 |
harriris-vincit
approved these changes
Feb 6, 2024
Add also e2e tests for missing footer links
Nice to have e2e-tests as a part of the review pipeline. I fixed failing e2e-tests and added also some new one for the new footer links. Hopefully the pipeline will pass after these changes. |
|
LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr330-ui.dev.hel.ninja 🚀🚀🚀 |
e2e tests result is success for https://linkedcomponents-pr330-ui.dev.hel.ninja 😆🎉🎉🎉 |
|
jorilindell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix failing test by is caused by the missing prop in the test file.
Fix failing e2e tests.
Add e2e tests for the footer links which still are missing tests
Closes
LINK-1891