Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LINK-1888 | 1/4 Price group list page #344

Merged
merged 7 commits into from
Mar 15, 2024
Merged

LINK-1888 | 1/4 Price group list page #344

merged 7 commits into from
Mar 15, 2024

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Feb 28, 2024 •
edited
Loading

Description

Page to list and search price groups

This is 1st of the PRs to implement price group admin pages. All PRs are:

Partially closes

LINK-1888

Screenshot

Screenshot 2024-03-03 at 22 08 41

@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr344-ui.dev.hel.ninja 🚀🚀🚀

@jorilindell jorilindell force-pushed the feature/LINK-1888-1_price-group-list-page branch from 297a9c3 to e1584e2 Compare February 28, 2024 20:17
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr344-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr344-ui.dev.hel.ninja 😆🎉🎉🎉

@jorilindell jorilindell force-pushed the feature/LINK-1888-1_price-group-list-page branch from e1584e2 to c0b0d9c Compare February 29, 2024 07:01
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr344-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr344-ui.dev.hel.ninja 😆🎉🎉🎉

@jorilindell jorilindell force-pushed the feature/LINK-1888-1_price-group-list-page branch from c0b0d9c to f37efea Compare February 29, 2024 09:26
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr344-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr344-ui.dev.hel.ninja 😆🎉🎉🎉

@jorilindell jorilindell force-pushed the feature/LINK-1888-1_price-group-list-page branch from f37efea to 945dd40 Compare February 29, 2024 12:05
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr344-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr344-ui.dev.hel.ninja 😆🎉🎉🎉

This was referenced Mar 3, 2024
Merged
Merged
Merged
@jorilindell jorilindell marked this pull request as ready for review March 4, 2024 07:12
@jorilindell jorilindell requested review from harriris-vincit and a team March 4, 2024 07:12
@jorilindell jorilindell mentioned this pull request Mar 4, 2024
Closed
@jorilindell jorilindell force-pushed the feature/LINK-1888-1_price-group-list-page branch from 945dd40 to a31daa8 Compare March 4, 2024 14:37
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr344-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr344-ui.dev.hel.ninja 😆🎉🎉🎉

harriris-vincit
harriris-vincit approved these changes Mar 12, 2024
View reviewed changes
Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments about translations, but otherwise LGTM.

harriris-vincit
harriris-vincit requested changes Mar 12, 2024
View reviewed changes
Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have a bug that causes an empty page to occur when first searching price groups with a non-existent value (I used the string "agg") and then removing the search term.

@jorilindell jorilindell force-pushed the feature/LINK-1888-1_price-group-list-page branch from a31daa8 to 610d13a Compare March 12, 2024 12:36
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr344-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr344-ui.dev.hel.ninja 😆🎉🎉🎉

@jorilindell
Copy link
Contributor Author

Seems to have a bug that causes an empty page to occur when first searching price groups with a non-existent value (I used the string "agg") and then removing the search term.

Fixed the bug in this PR as well. PR can now be re-reviewed.

@jorilindell
feat: create price group page
1445659
@jorilindell
chore: remove duplicate code from tests
639cf83 
- use openDropdownMenu util function to open dropdown menu
- use shouldRenderDeleteModal util function to test that correct delete modal texts and are visible
- use shouldSetGenericServerErrors util function to test that generic server errors are set correctly
- use shouldSetServerErrors util function to test that server errors are set correctly
- use shouldApplyExpectedMetaData util function to test that page meta data is set correctly
- use shouldDeleteInstance util function to test that instance is deleted and confirmation message is displayed
- use shouldClickButton util function to test that modal button is clicked
- use shouldRenderListPage util function to test that all list page elements are rendered
- use shouldSortListPageTable util function to test that list page table is sorted correctly
- use shouldClickListPageCreateButton util function to test that list page create button works
harriris-vincit
harriris-vincit approved these changes Mar 13, 2024
View reviewed changes
Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge PR, but LGTM 👍

@jorilindell
Merge pull request #347 from City-of-Helsinki/feature/LINK-1888-4_rem…
57e6671 
…ove-duplicate-test-code

LINK-1888 | 4/4 Remove duplicate code from tests
@jorilindell
Merge pull request #346 from City-of-Helsinki/feature/LINK-1888-3_pri…
6d3bdb9 
…ce-group-create-page

LINK-1888 | 3/4 Create price group page
@jorilindell
Merge pull request #345 from City-of-Helsinki/feature/LINK-1888-2_pri…
196c014 
…ce-group-edit-page

LINK-1888 | 2/4 Edit price group page
@terovirtanen
Copy link
Contributor

LINKEDCOMPONENTS-UI branch is deployed to platta: https://linkedcomponents-pr344-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://linkedcomponents-pr344-ui.dev.hel.ninja 😆🎉🎉🎉

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jorilindell jorilindell merged commit f22d475 into main Mar 15, 2024
19 of 20 checks passed
@jorilindell jorilindell deleted the feature/LINK-1888-1_price-group-list-page branch March 15, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harriris-vincit harriris-vincit harriris-vincit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorilindell @terovirtanen @harriris-vincit