Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINK-1777 | Remove mandatory fields validation from contact person fields #114

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Nov 29, 2023

Description

API doesn't support mandatory fields validation for contact person fields so remove it here as well

Closes

LINK-1777

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8232524) 99.61% compared to head (aed5f53) 99.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files         188      188           
  Lines        3631     3631           
  Branches      595      595           
=======================================
  Hits         3617     3617           
  Misses         13       13           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@harriris-vincit harriris-vincit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

API doesn't support dynamic mandatory fields for contact persons so remove it here as well
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@jorilindell jorilindell merged commit 602f02e into main Dec 7, 2023
5 checks passed
@jorilindell jorilindell deleted the fix/LINK-1777 branch December 7, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants