Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINK-1369 | Support multilingual confirmation_message and instructions fields #53

Merged

Conversation

jorilindell
Copy link
Contributor

@jorilindell jorilindell commented Jun 12, 2023

Description ✨

Show correct language version of the confirmation message and add registration instructions to event info

PR to BE implementation: City-of-Helsinki/linkedevents#610

Closes

LINK-1369

Screenshots

Screenshot 2023-06-12 at 18 20 37

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023

Codecov Report

Merging #53 (9bb2e59) into develop (465285b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop      #53   +/-   ##
========================================
  Coverage    99.82%   99.82%           
========================================
  Files          124      125    +1     
  Lines         2226     2244   +18     
  Branches       357      358    +1     
========================================
+ Hits          2222     2240   +18     
  Misses           4        4           
Impacted Files Coverage Δ
src/domain/enrolment/EnrolmentCompletedPage.tsx 100.00% <100.00%> (ø)
...olment/confirmationMessage/ConfirmationMessage.tsx 100.00% <100.00%> (ø)
src/domain/enrolment/eventInfo/EventInfo.tsx 100.00% <100.00%> (ø)
src/domain/enrolment/instructions/Instructions.tsx 100.00% <100.00%> (ø)
.../summaryPage/summaryEventInfo/SummaryEventInfo.tsx 100.00% <100.00%> (ø)
src/domain/registration/utils.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jorilindell jorilindell force-pushed the feature/LINK-1369-multilingual-registration-fields branch from 0168338 to 95594c4 Compare June 14, 2023 08:16
- Enrolment is closed if enrolment_start_time is defined and is in the future or enrolment_end_time is defined and is in the past
- Show different warning message if enrolment is open but there is no available seats
- Add reserved seats to available seats amount if there is already reservation in the session storage
- Disable enrolment form also if there is no available places and seats reservation is not stored to session storage

Revert "Prevent to reserve seats or signup is enrolment is not open"

This reverts commit adeed9b.
@jorilindell jorilindell force-pushed the feature/LINK-1369-multilingual-registration-fields branch from 95594c4 to 9bb2e59 Compare June 27, 2023 08:46
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jorilindell jorilindell merged commit 42dad35 into develop Jun 27, 2023
4 checks passed
@jorilindell jorilindell deleted the feature/LINK-1369-multilingual-registration-fields branch June 27, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants