LINK-1367 | Support multilingual confirmation_message and instructions #610

jorilindell · 2023-06-12T09:07:38Z

Description

At the moment confirmation_message and instructions fields in SignUp model are single text fields. Change them to multilingual text fields.

Closes

LINK-1367

codecov-commenter · 2023-06-12T09:16:52Z

Codecov Report

Merging #610 (7c113ec) into develop (73e6968) will increase coverage by 0.06%.
The diff coverage is 97.91%.

@@             Coverage Diff             @@
##           develop     #610      +/-   ##
===========================================
+ Coverage    73.67%   73.74%   +0.06%     
===========================================
  Files          231      233       +2     
  Lines        16128    16170      +42     
===========================================
+ Hits         11882    11924      +42     
  Misses        4246     4246

Impacted Files	Coverage Δ
events/tests/conftest.py	`98.02% <ø> (ø)`
registrations/models.py	`98.13% <92.85%> (+0.11%)`	⬆️
...tilingual_confirmation_message_and_instructions.py	`100.00% <100.00%> (ø)`
registrations/tests/test_models.py	`100.00% <100.00%> (ø)`
registrations/tests/test_signup_post.py	`100.00% <100.00%> (ø)`
registrations/translation.py	`100.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tuomas777 · 2023-06-22T08:05:24Z

registrations/models.py

+            "event": getattr(
+                self.registration.event,
+                f"name_{service_language}",
+                self.registration.event.name,
+            ),


Unless there is a specific reason why not, it would be cleaner to use django-modeltranslation's standard way of accessing the translated fields, ie.

with translation.override(service_language): email_variables = { ... "event": self.registration.event ... }

One thing to consider is what kind of fallback language logic we want to use with these fields, and configure modeltranslation accordingly.

Great! I was quite sure that my approach wan't the best possible. Changed as suggested. Added Finnish, Swedish and English as fallback language for confirmation_message and instructions fields.